migrate to labels for search fields #262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoglo
previously approved these changes
Jun 24, 2024
There was a problem hiding this comment.
We may want to re-add the cursor pointer since it's gone due to label having higher specificity than the class in their parent-element.
If you change this to the following code, it should work:
.input-group,
.form-select,
.cursor-pointer,
label.input-group-text {
cursor: pointer;
}
# Conflicts: # src/components/search/autocompletion.tsx
zoglo
approved these changes
Jul 10, 2024
|
Converting to a draft due to duplicate ids. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously manually querying for elements and controlling their focus state.
instead we'll use
labelelements and let that element handle it as intended.some
ids are changed in this PR to try and ensure no conflicts if there are more than 1 search on the same page. we'll need to be more exhaustive about this in the future. maybe a lint rule could catch this.