Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [AsyncAwsS3] update simpleS3 for test and adjust getPresignedUrl declaration #1748

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix: [AsyncAwsS3] update simpleS3 for test and adjust getPresignedUrl declaration #1748

merged 1 commit into from
Feb 4, 2024

Conversation

tinect
Copy link
Contributor

@tinect tinect commented Feb 3, 2024 •
edited
Loading

Fixes the tests.

PHP Fatal error: Declaration of League\Flysystem\AsyncAwsS3\S3ClientStub::getPresignedUrl(string $bucket, string $key, ?DateTimeImmutable $expires = null): string must be compatible with AsyncAws\SimpleS3\SimpleS3Client::getPresignedUrl(string $bucket, string $key, ?DateTimeImmutable $expires = null, ?string $versionId = null): string in /home/runner/work/flysystem/flysystem/src/AsyncAwsS3/S3ClientStub.php on line 184

webdav is fixed here #1746

@frankdejonge frankdejonge merged commit 7754a6a into thephpleague:3.x Feb 4, 2024
1 of 5 checks passed
@tinect tinect deleted the fix/updateSimpleS3 branch February 4, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinect @frankdejonge