Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28154 - random name/description test failure fixed #7142

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

lzap
Copy link
Member

@lzap lzap commented Oct 30, 2019

Due to generation of UTF8 Chinese characters up to 255 and storing them into name/description field with 255 bytes limit. This is UTF8 vs bytes problem, generated random UTF8 data must be truncated not to exceed the limit.

test/test_helper.rb Outdated Show resolved Hide resolved
lib/core_extensions.rb Outdated Show resolved Hide resolved
@theforeman-bot
Copy link
Member

Issues: #28154

@lzap lzap force-pushed the rfauxfactory-length-28154 branch from d81b9c9 to 90164d7 Compare October 30, 2019 13:16
@lzap
Copy link
Member Author

lzap commented Oct 30, 2019

Usergroup is another random failure, unrelated?!?

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like something that should be fixed at the gem level, but i'll merge now to unblock the pipelines.

@tbrisker tbrisker merged commit db6f2df into theforeman:develop Oct 31, 2019
@lzap lzap deleted the rfauxfactory-length-28154 branch October 31, 2019 13:28
@lzap
Copy link
Member Author

lzap commented Oct 31, 2019

Yeah probably: SatelliteQE/RFauxFactory#12

@tbrisker
Copy link
Member

tbrisker commented Nov 4, 2019

1.22 - bcf11c8
1.23 - c5cf075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants