-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and improve bootstrap form #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iibarbari
added
status: ready for review
status: in progress
and removed
status: in progress
status: ready for review
labels
Nov 1, 2024
iibarbari
added
status: in progress
status: ready for review
and removed
status: ready for review
status: in progress
labels
Nov 5, 2024
iibarbari
added
status: in progress
status: ready for review
and removed
status: ready for review
status: in progress
labels
Nov 5, 2024
th0th
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some change requests, and asked some questions, too 💐
th0th
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the frontend and backend components, focusing on improving the user interface and user experience, particularly around the Bootstrap process and the Activity Overlay component.
Frontend Changes:
Activity Overlay Component:
ActivityOverlay
component with styles and functionality to display an overlay and spinner during loading states. (frontend/src/components/ActivityOverlay/ActivityOverlay.module.css
- [1]frontend/src/components/ActivityOverlay/index.tsx
- [2]Bootstrap Component:
frontend/src/components/Bootstrap/index.tsx
- [1] [2] [3] [4] [5] [6] [7]frontend/src/components/Bootstrap/Bootstrap.module.css
- [1] [2]Layout Component:
Layout
component to standardize the page layout, including an option to vertically center content. (frontend/src/components/Layout/Layout.module.css
- [1]frontend/src/components/Layout/index.tsx
- [2]General UI Improvements:
frontend/src/styles/components.css
- [1] [2] [3] [4] [5]frontend/src/components/Collapse/Collapse.module.css
- [6] [7]frontend/src/components/Collapse/index.tsx
- [8] [9]Backend Changes:
backend/pkg/restapi/handler/bootstrap/main.go
- backend/pkg/restapi/handler/bootstrap/main.goR74)These changes aim to enhance the overall user experience by making the interface more responsive and providing clearer feedback during critical operations like the Bootstrap process.