Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat: add event filters to event log table (#207)" #266

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

smeijer
Copy link
Member

@smeijer smeijer commented Aug 3, 2020

What:
I need to revert #207 (commit 6c47c12) for the time being.

Why:
The changes that were applied, make the event log terribly slow. We need to find a better way later.

How:

git revert 6c47c128

Checklist:

  • Tests
  • Ready to be merged

@smeijer smeijer added the chore label Aug 3, 2020
@smeijer smeijer self-assigned this Aug 3, 2020
@smeijer smeijer changed the title Revert "feat: add event filters to event log table (#207)" revert: "feat: add event filters to event log table (#207)" Aug 3, 2020
@smeijer smeijer merged commit 85aeb55 into develop Aug 3, 2020
@smeijer smeijer deleted the feature/event-filter branch August 3, 2020 15:58
@delca85
Copy link
Member

delca85 commented Aug 3, 2020

Have you noticed some principal cause of slowness? I could work on it trying to make some improvements.

@smeijer
Copy link
Member Author

smeijer commented Aug 3, 2020

Hi @delca85, I'm very sorry for the revert!

I don't really know why it was slow. But it was terribly lagging. Not just a little bit. I'm not sure what's going on though.

I'll try upload a video in a moment.

@delca85
Copy link
Member

delca85 commented Aug 3, 2020

Don't worry, it is not a problem at all!

When I have developed it I haven't noticed this slowness but I am sure it is real right now and revert it has been the perfect choice 😊

Given that, if you agree I would be happy to work on it again.

@smeijer
Copy link
Member Author

smeijer commented Aug 3, 2020

Yeah, that's fine. If you want to take another shot, that would be great.

Not sure what's better though, try to fix the branch as it was, or to change the approach.

@delca85
Copy link
Member

delca85 commented Aug 3, 2020

Hey @smeijer, when you have some time could you please upload the video you spoke about some comments ago?
Just to make me more aware of the problem! Thanks!

@delca85
Copy link
Member

delca85 commented Aug 3, 2020

What looks like laggy to me happens when:

  1. populate table with some events
  2. deselect an event type (or name) that is the same type (or name) of any event is viewable in the table at the moment
  3. event with the deselected type (or name) disappears from the table and the table shows some rows missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants