Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added prefix filter option #544

Merged
merged 20 commits into from
Jan 10, 2025
Merged

feat: added prefix filter option #544

merged 20 commits into from
Jan 10, 2025

Conversation

Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Oct 7, 2024

Description

Added support to add prefix filter.
Git Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Added a featrure to add prefix filters to the transit gateway connections that can be used to permit or deny specific IP address ranges (called prefixes) on specific network connections.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
examples/add-prefix-filter/main.tf Outdated Show resolved Hide resolved
@Ak-sky
Copy link
Member Author

Ak-sky commented Dec 13, 2024

/run pipeline

@Ak-sky Ak-sky requested a review from vbontempi December 13, 2024 12:23
@Ak-sky
Copy link
Member Author

Ak-sky commented Dec 18, 2024

There is an update in place which should not occur- raised provider bug.

  # module.tg_gateway_connection.ibm_tg_connection_prefix_filter.add_prefix_filter[1] will be updated in-place
  ~ resource "ibm_tg_connection_prefix_filter" "add_prefix_filter" {
      - before        = "c88803e8-0d94-40dd-8154-39f8c74141ce" -> null
        id            = "c38857de-78f9-4eaf-bf5f-6ee8c35a305a/bec98499-f3aa-4a47-b6c3-e9c00bf41872/d5d7fbd7-32a2-4d5c-89ad-77b9eddd4cff"
        # (9 unchanged attributes hidden)
    }

@Ak-sky
Copy link
Member Author

Ak-sky commented Dec 19, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Dec 19, 2024

/run pipeline

Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion for a description

variables.tf Outdated Show resolved Hide resolved
@Ak-sky
Copy link
Member Author

Ak-sky commented Dec 19, 2024

/run pipeline

@Ak-sky Ak-sky requested a review from vbontempi December 19, 2024 20:41
@vbontempi
Copy link
Member

/run pipeline

vbontempi
vbontempi previously approved these changes Dec 23, 2024
Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

examples/add-prefix-filter/README.md Show resolved Hide resolved
@Ak-sky
Copy link
Member Author

Ak-sky commented Jan 8, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jan 8, 2025

/run pipeline

Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me now

@maheshwarishikha maheshwarishikha merged commit 770c73f into main Jan 10, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the filter branch January 10, 2025 07:55
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants