-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(x11/far2l): 2.6.4 #22608
base: master
Are you sure you want to change the base?
bump(x11/far2l): 2.6.4 #22608
Conversation
spvkgn
commented
Dec 18, 2024
•
edited by Biswa96
Loading
edited by Biswa96
- bump far2l to 2.6.4
- add far2l-plugins-colorer subpackage
- Fixes Auto update failing for far2l #22313
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, just have a couple things I wanna clear up before merge.
TERMUX_PKG_REVISION=1 | ||
TERMUX_PKG_SRCURL=https://github.com/elfmz/far2l/archive/refs/tags/v_${TERMUX_PKG_VERSION}.tar.gz | ||
TERMUX_PKG_SHA256=ffb216a4f9b24bb45a2194d5e833c60334a4f4e9150c1ce0fc8eddffa6a9e173 | ||
TERMUX_PKG_DEPENDS="libarchive, libc++, libuchardet, pcre" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is pcre
(or pcre2
) not supported anymore?
@@ -2,17 +2,17 @@ TERMUX_PKG_HOMEPAGE=https://github.com/elfmz/far2l | |||
TERMUX_PKG_DESCRIPTION="FAR Manager v2" | |||
TERMUX_PKG_LICENSE="GPL-2.0" | |||
TERMUX_PKG_MAINTAINER="@termux" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider setting yourself as the package maintainer.
This field is mostly a point of contact for us to know who is working on a package.
It doesn't mean you have to do everything related to a package.
@@ -2,17 +2,17 @@ TERMUX_PKG_HOMEPAGE=https://github.com/elfmz/far2l | |||
TERMUX_PKG_DESCRIPTION="FAR Manager v2" | |||
TERMUX_PKG_LICENSE="GPL-2.0" | |||
TERMUX_PKG_MAINTAINER="@termux" | |||
TERMUX_PKG_VERSION="2.6.3" | |||
TERMUX_PKG_VERSION="2.6.4" | |||
TERMUX_PKG_REVISION=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package revisions on Termux start at 0.
Please remove this line.
TERMUX_PKG_REVISION=1 |
I will rebase to check libnfs compatibility |