Various improvements #331
Merged
Various improvements #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 9 out of 24 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- src/FarkleNeo/Farkle.fs: Language not supported
- src/FarkleNeo/Grammars/GoldParser/GoldGrammarConverter.cs: Evaluated as low risk
- src/FarkleNeo/Builder/Untyped.cs: Evaluated as low risk
- src/FarkleNeo/Builder/OperatorPrecedence/OperatorScope.cs: Evaluated as low risk
- src/FarkleNeo/Grammars/EntityHandle.cs: Evaluated as low risk
- src/FarkleNeo/Builder/Dfa/DfaBuild.cs: Evaluated as low risk
- src/FarkleNeo/Grammars/StateMachines/Dfa.cs: Evaluated as low risk
- src/FarkleNeo/DebuggerTypeProxies.cs: Evaluated as low risk
- src/FarkleNeo/Grammars/StateMachines/DfaEdge.cs: Evaluated as low risk
- src/FarkleNeo/Grammars/Writers/GrammarWriter.cs: Evaluated as low risk
- sample/Farkle.Samples.CSharp/JSON.cs: Evaluated as low risk
- src/FarkleNeo/Grammars/GrammarExtensions.cs: Evaluated as low risk
- src/FarkleNeo/Grammars/GoldParser/GrammarBinaryReader.cs: Evaluated as low risk
- src/FarkleNeo/Grammars/Grammar.cs: Evaluated as low risk
- src/FarkleNeo/Builder/ObjectModel.cs: Evaluated as low risk
Comments skipped due to low confidence (5)
src/FarkleNeo/Grammars/Production.cs:82
- The phrase 'the the' should be corrected to 'the'.
/// Returns a string describing the the <see cref="Production"/>.
src/FarkleNeo/Grammars/Nonterminal.cs:87
- The word 'the' is repeated. It should be 'Returns a string describing the '
/// Returns a string describing the the <see cref="Nonterminal"/>.
src/FarkleNeo/Grammars/Nonterminal.cs:79
- The Equals method should be covered by tests to ensure it behaves correctly.
public bool Equals(Nonterminal other) => _grammar == other._grammar && Handle == other.Handle;
src/FarkleNeo/Grammars/TokenSymbol.cs:92
- The comment contains a double 'the'. It should be corrected to 'Returns a string describing the .'
/// Returns a string describing the the <see cref="TokenSymbol"/>.
src/FarkleNeo/Grammars/Group.cs:121
- The comment contains a spelling mistake: 'describing the the' should be 'describing the'.
/// Returns a string describing the the <see cref="Group"/>.
The original plan was to do it only for handles, but since we almost everywhere use concrete objects, they should support equality as well.
It can be done with one line since .NET 9 and with a few more lines in earlier frameworks.
This allows us to accept params immutable array when setting typed productions.
It no longer depends on the result type at all, and the APIs that don't even depend on the character type are moved to a non-generic class.
We use `Load` instead of `Create` and `Convert` for GOLD Parser grammar conversions. The read-only span overload was removed because it always had to copy the span if the grammar is valid. Better make memory management explicit to the user. Also added an API to convert a GOLD Parser grammar from a file.
teo-tsirpanis
force-pushed
the
various-improvements
branch
from
cdc96bb to
5d26f9b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.