Added call to close() function for 'file_train' and 'file_test' #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamtekson
approved these changes
Jul 7, 2022
|
Sorry, I accidentally marked it as draft. I marked it again as ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues
None
What does this fix?
In 99.9% of the cases not closing an opened txt file is not going to do any harm, but still it is best practice to do so. In the "process.py" script the two files "train.txt" and "test.txt" are opened with open() but never closed.
Other comments
I have made the same pull request with the same minor fix to the "yolov4-custom_Training" repository. Again: your tutorials have helped me a lot while configuring/using the darknet framework, so again: thank you! 💖