refactor link creation

tchoutri · Jul 20, 2024 · d123343 · d123343
1 parent af2628e
commit d123343
Showing 1 changed file with 28 additions and 5 deletions.
diff --git a/src/Confer/Effect/Symlink.hs b/src/Confer/Effect/Symlink.hs
@@ -73,14 +73,13 @@ runSymlinkIO = interpret $ \_ -> \case
     sourceType <- liftIO $ do
       metadata <- Directory.getFileMetadata source
       pure $ Directory.fileTypeFromMetadata metadata
-    sourceFilePath <- liftIO $ OsPath.decodeFS source
-    sourcePath <- FileSystem.makeAbsolute sourceFilePath
+    sourcePath <- FileSystem.makeAbsolute =<< liftIO (OsPath.decodeFS source)
     destinationPath <- liftIO $ OsPath.decodeFS destination
     case sourceType of
       File -> do
         destinationExists <- FileSystem.doesFileExist destinationPath
         if destinationExists
-          then Error.throwError (AlreadyExists destination)
+          then handleAlreadyExistingDestination sourcePath destinationPath
           else createFileLink sourcePath destinationPath
       Directory ->
         createDirectoryLink sourcePath destinationPath
@@ -90,10 +89,10 @@ runSymlinkIO = interpret $ \_ -> \case
       metadata <- Directory.getFileMetadata linkOsPath
       pure $ Directory.fileTypeFromMetadata metadata
     case sourceType of
-      File ->
-        FileSystem.removeFile linkFilePath
       Directory ->
         FileSystem.removeDirectory linkFilePath
+      _ ->
+        FileSystem.removeFile linkFilePath
   TestSymlink linkOsPath expectedLinkTarget -> do
     linkFilepath <- liftIO $ OsPath.decodeFS linkOsPath
     liftIO $
@@ -145,3 +144,27 @@ runSymlinkPure virtualFS = reinterpret (State.evalState virtualFS) $ \_ -> \case
                     actualLinkTarget
                 )
       Nothing -> pure $ Left (DoesNotExist linkPath)
+
+handleAlreadyExistingDestination
+  :: (FileSystem :> es, Error SymlinkError :> es, IOE :> es)
+  => FilePath
+  -> FilePath
+  -> Eff es ()
+handleAlreadyExistingDestination sourcePath destinationPath = do
+  source <- liftIO $ OsPath.encodeFS sourcePath
+  destination <- liftIO $ OsPath.encodeFS destinationPath
+  destinationType <- liftIO $ do
+    metadata <- Directory.getFileMetadata destination
+    pure $ Directory.fileTypeFromMetadata metadata
+  if Directory.fileTypeIsLink destinationType
+    then do
+      destinationTruePath <-
+        liftIO $
+          Directory.readSymbolicLink destination
+      if destinationTruePath == source
+        then do
+          liftIO $
+            putStrLn $
+              destinationPath <> " already points to " <> sourcePath <> "."
+        else Error.throwError (AlreadyExists destination)
+    else createFileLink sourcePath destinationPath