Correct definition of JSC "runtime" object #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit [1] regressed support for JavaScriptCore by changing the way the "runtime" object is defined for that engine. Restore the intended behavior and add an automated test. [1] 4e9c3ee
rwaldron
approved these changes
Jun 24, 2021
|
@rwaldron Can you update test262-harness too? https://github.com/bterlson/test262-harness |
|
The test262-harness project currently depends on eshost with the version specifier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit [1] regressed support for JavaScriptCore by changing the
way the "runtime" object is defined for that engine. Restore the
intended behavior and add an automated test.
[1] 4e9c3ee
The CI system is not currently configured to validate this change (or any other change) in JavaScriptCore. See gh-112 for that.
The regression has been observed in results published to test262.report: bocoup/test262-report-issue-tracker#28