Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unpinning buttons and clear button to pin list #560

Merged
merged 8 commits into from
Nov 3, 2023
Merged

add unpinning buttons and clear button to pin list #560

merged 8 commits into from
Nov 3, 2023

Conversation

michaelficarra
Copy link
Member

Fixes #438.

image

@michaelficarra michaelficarra requested a review from bakkot November 2, 2023 16:51
#references-pane-container.active {
display: flex;
}

#references-pane-close:after {
content: '';
content: '\2716';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a drive-by fix for an encoding error I got when doing local testing from a file:// URL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... is that seriously how one spells hex escapes in CSS? Gross.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@bakkot bakkot merged commit b3ad219 into main Nov 3, 2023
2 checks passed
@bakkot bakkot deleted the GH-438 branch November 3, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the pinned items should have a button next to them for easy unpinning
2 participants