Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ja): "Quick Start" Section #3111

Merged
merged 63 commits into from
Feb 25, 2025
Merged

i18n(ja): "Quick Start" Section #3111

merged 63 commits into from
Feb 25, 2025

Conversation

J1-takai
Copy link
Contributor

@J1-takai J1-takai commented Jan 8, 2025

i18n (JP) Translation for "Quick Start" section

  • What does this PR change? Give us a brief description.
    This is a trial translation work for "Tauri Doc 2.0 Japanese Version" from the scratch. If there are any similar activities already on-going, please disregard this pull request. If not, my drafts would need technical proof-reading as I have almost no knowledge on programming - my only programming experiences were introductory courses for FORTRAN and COBOL using punch cards data loading some 40 years ago, HA HA! No rush - Please take your time.
  • Closes #

@J1-takai J1-takai requested a review from a team as a code owner January 8, 2025 14:03
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8dda9e2
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/67bdd9c2ff319400083bb63f
😎 Deploy Preview https://deploy-preview-3111--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added i18n Is this related to translations? i18n: ja labels Feb 11, 2025
@vasfvitor
Copy link
Contributor

@penginnu hi again, thanks for your help. You can start at this PR

just ignore those files listed here concept directory: 26fb977 as they are intended for another PR and are incomplete
image

those files are to be reviewed:
src/content/docs/ja/index.mdx
src/content/docs/ja/rss.mdx
image

General guidelines https://github.com/tauri-apps/tauri-docs/blob/4f3f5012e5a463653c8f61861de9ea7eba8727f5/.github/TRANSLATING.md

The main point is to avoid typos, sentences that are too far from the original meaning, unrelated/uneeded changes

@penginnu
Copy link
Contributor

penginnu commented Feb 11, 2025

@vasfvitor Thank you!
I will proceed to review the following documents.

  • src/content/docs/ja/index.mdx
  • src/content/docs/ja/rss.mdx
  • src/content/docs/ja/start/**/*

I have some knowledge of astrojs, tauri and nodejs, but I am not familiar with translations, so I may cause you some inconvenience ...

Copy link
Contributor

@penginnu penginnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a review for rss.mdx. And, an easily found tag error.
Looking forward to working with you!

@J1-takai
Copy link
Contributor Author

@vasfvitor @penginnu

Thx for ur quick actions. Since I am a non-programmer (& retired old man), @penginnu-san's reviews on the technical aspect of my translations are highly appreciated.

Regarding a feature branch idea, this may be a good idea to proceed the large document site like Tauri. I will check how to do it.
I use the VSCode for my translation (.md editing only) but only limited functions are used as a beginner 🔰. This is probably why the format errors occurs on my translated files. I shall improve someday.

@vasfvitor
Copy link
Contributor

@J1-takai have you managed to copy the "concept" page drafts to a new branch?

@vasfvitor
Copy link
Contributor

This is probably why the format errors occurs on my translated files. I shall improve someday.

Format errors will happen regardless, it's just a way to ensure we have a default formatting, so we can track only real changes, not formatting. If you can manage to, run pnpm format, it will format based on our set of rules

@J1-takai
Copy link
Contributor Author

@vasfvitor Yes, I copied the concept files into the separate folder. Also I am now working using the new branch "Concept-ja". As for running pnpm format, I cannot find the way how to do it. Note: Node v23.7.0 and pnpm v10.3.0 were successfully installed in my Linux PC. How can I use pnpm in VS Code?

@vasfvitor
Copy link
Contributor

vasfvitor commented Feb 13, 2025

basically you open a terminal at the cloned repository and run pnpm i once to install the packages. Afterwards pnpm format will be available. It can be your system terminal or vscode's integrated. To preview locally you need to run pnpm dev:setup once, then pnpm dev to start the local server

@J1-takai
Copy link
Contributor Author

@vasfvitor
Thank you for your advice on "pnpm format". I tried this but there seems to be no PATH to Node.js from VS Code (I received "No pnpm command is found" message. I'll check the solution somehow.

@vasfvitor
Copy link
Contributor

you should be able to open any terminal and enter pnpm -v, and node -v. If any of those doesn't work, then you gotta review their installation, usually making sure they're on PATH. You don't need to specifically use vscode integrated terminal. You can open any terminal and cd cloned-tauri-docs-repo

@J1-takai
Copy link
Contributor Author

@vasfvitor Thank you for your many advice, but the problem still exists - this time I tried the node/pnpm in the local directory of Tauri-Docs, but the error message "pnpm CLI is missing" occurred - in the local directory Node -v works but pnpm -v failed. I decided to put this issue aside for the time being and proceed the translation work. Thank you again for your help.

@J1-takai
Copy link
Contributor Author

@vasfvitor @penginnu
I updated the JA Translation Tracker files as attached. Looks like lots of fun(?) ahead!!
Tauri i18n(ja) Translation Status List 2025-02-15.xlsx

@vasfvitor
Copy link
Contributor

it's ok, last note is that generally you'd have to run corepack enable pnpm to enable it. I assume you may have installed npm that comes with node, and not pnpm that you have to enable

@J1-takai
Copy link
Contributor Author

@vasfvitor
Thank you for your "last" note. After fiddling "corepack", re-installation of "nvm" & "node.js", changing pnpm version to "9.x.x" etc several times, suddenly the pnpm format [seemed to have] worked (I think) in the local directory: see screenshot below.

pnpm-format-result

Most of the files are shown "unchanged" (of course), but my changed files in CONCEPT folder seems to be prettified (I do not know what or where is changed though). In any case, this must be a good omen for i18n(ja). Thank you for your patience. Now it's time to get back to work!!

@vasfvitor vasfvitor merged commit 00714d3 into tauri-apps:v2 Feb 25, 2025
9 checks passed
@J1-takai
Copy link
Contributor Author

@vasfvitor thank you very much for your great support on this. I'll continue my effort on the remaining sections one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n: ja i18n Is this related to translations?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants