fix spaces vs tabs issue with dredd / delete todos after running tests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the current frontend expect 'completed' not 'done. |
|
😕 I don't know where I got done from, but now it's all over the place! I'll change back to completed. |
| todosToDelete.forEach(function (todo, index, todos) { | ||
| request.del(uri('/todos/' + todo.id), function (err) { | ||
| if (err) { | ||
| completeHook(err); |
There was a problem hiding this comment.
will that interrupt the iteration?
|
LGTM, merging. |
proppy
added a commit
that referenced
this pull request
Oct 28, 2014
fix spaces vs tabs issue with dredd / delete todos after running tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs were breaking the apib file (my bad!), so I switched it back to our original format.
In a new afterAll hook, I'm getting all todos and deleting the ones we created -- the differentiator is the title: "dredd".
@proppy is there a better way to do any of these changes?