Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tangle-dapp): Add TNT Rewards, Fix TVL Calculation #2795

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented Feb 4, 2025

Summary of changes

Provide a detailed description of proposed changes.

  • Fix the total TVL calculation for each asset.
  • Fix the delegated amount / deposited amount for each asset.
  • Replace deposit APY in % to TNT rewards.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

CleanShot 2025-02-05 at 16 55 08@2x

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit c02a6d1
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67a34eee21ce920008b59b52
😎 Deploy Preview https://deploy-preview-2795--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit c02a6d1
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67a34eeecf2410000885f280
😎 Deploy Preview https://deploy-preview-2795--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AtelyPham AtelyPham marked this pull request as draft February 4, 2025 19:32
@AtelyPham AtelyPham self-assigned this Feb 4, 2025
@AtelyPham AtelyPham changed the title feat(tangle-dapp): Replace Deposit APY in % to TNT Rewards feat(tangle-dapp): Add TNT Rewards, Fix TVL Calculation Feb 4, 2025
Copy link
Contributor

@monaiuu monaiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix table divider misplacement and items alignment:
Screenshot 2025-02-05 at 12 05 07 PM

Also question, from what @1xstj told me users cannot deposit beyond the deposit capacity. Wanna double check if this amount is correct since TVL is greater than the capacity here:
Screenshot 2025-02-05 at 12 08 09 PM

@yurixander
Copy link
Member

Fix table divider misplacement and items alignment: Screenshot 2025-02-05 at 12 05 07 PM

Also question, from what @1xstj told me users cannot deposit beyond the deposit capacity. Wanna double check if this amount is correct since TVL is greater than the capacity here: Screenshot 2025-02-05 at 12 08 09 PM

@monaiuu BTW, if that's from testnet, testnet has a runtime that seems to have outdated logic in terms of limiting the max deposit...

@AtelyPham
Copy link
Member Author

Fix table divider misplacement and items alignment: Screenshot 2025-02-05 at 12 05 07 PM
Also question, from what @1xstj told me users cannot deposit beyond the deposit capacity. Wanna double check if this amount is correct since TVL is greater than the capacity here: Screenshot 2025-02-05 at 12 08 09 PM

@monaiuu BTW, if that's from testnet, testnet has a runtime that seems to have outdated logic in terms of limiting the max deposit...

Yes, I've informed @1xstj about this runtime bug.

@AtelyPham AtelyPham marked this pull request as ready for review February 5, 2025 09:52
@AtelyPham AtelyPham requested a review from monaiuu February 5, 2025 09:57
@AtelyPham AtelyPham merged commit 8c6abac into develop Feb 5, 2025
16 checks passed
@AtelyPham AtelyPham deleted the trung-tin/update-annual-tnt-rewards branch February 5, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

[TASK] Replace Deposit APY in % to Annual TNT Rewards
3 participants