refactor(tangle-dapp): Integrate bridge ERC-20 tokens into restaking #2783
Conversation
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Progress:
|
yurixander
requested review from
AtelyPham,
devpavan04 and
monaiuu
as code owners
|
@yurixander I was able to bridge
CleanShot.2025-02-01.at.12.23.24.mp4As we discussed, these issues need to be addressed:
Otherwise, LGTM! |
| }), | ||
| ); | ||
| return Object.entries(delegatorInfo.deposits).map(([assetIdString]) => { | ||
| const availableForWithdrawal = calculateRestakeAvailableBalance( |
There was a problem hiding this comment.
The backend has a field called delegated_amount that indicates the total delegated amount, which can be used to calculate the available balance.
This issue has been addressed in PR #2788.
| (delegation) => delegation.assetId === selectedAsset.id, | ||
| )?.amountBonded ?? ZERO_BIG_INT; | ||
|
|
||
| const availableBalance = amountBigInt - delegatedBigInt; |
There was a problem hiding this comment.
The backend has a field called delegated_amount that indicates the total delegated amount, which can be used to calculate the available balance.
This issue has been addressed in PR #2788.
| (delegation) => delegation.assetId === assetId, | ||
| )?.amountBonded ?? ZERO_BIG_INT; | ||
|
|
||
| const balance = new BN((amount - delegatedAmount).toString()); |
There was a problem hiding this comment.
The backend has a field called delegated_amount that indicates the total delegated amount, which can be used to calculate the available balance.
This issue has been addressed in PR #2788.
There was a problem hiding this comment.
@AtelyPham I tested with these calculations, and everything seems to be in order, including after you deposit, delegate, withdraw, etc. all the values updated accordingly. Just to make sure, that's the same case for when you used delegated_amount?
There was a problem hiding this comment.
^ Also these tests were done with local dev on latest Tangle node changes, since testnet has different / incorrect values which seem to have been fixed on newer node updates.
| return {}; | ||
| } | ||
|
|
||
| const depositedAsset = Object.entries(delegatorInfo.deposits).find( | ||
| ([assetId]) => assetId === selectedAssetId, | ||
| const availableBalance = calculateRestakeAvailableBalance( |
There was a problem hiding this comment.
The backend has a field called delegated_amount that indicates the total delegated amount, which can be used to calculate the available balance.
This issue has been addressed in PR #2788.
|
Conflicts here |
|
@devpavan04 and I are seeing different TVL for WETH restake vault here, both on your latest open PR: My account: Pavan's account: |
There was a problem hiding this comment.
- to address [BUG] Fix Network Detection + Asset Rendering Issue #2765, let's also remove this selector so user cannot switch network from here. What's displayed here should always be synchronized with the network user is connected to, as displayed in top nav.
There was a problem hiding this comment.
The updated display in this PR reduces the "Deposits" amount when tokens are delegated, which could be misleading since it doesn't reflect the actual total deposits.
Proposing we modify the display to:
- always show the total deposits as the primary number
- show delegation info as secondary info (on hover), and make it clear that delegation is a subset of the total deposits rather than a reduction of deposits.
I think this better reflects our system's behavior where delegation is simply a action perform on deposited tokens, not a separate pool of tokens. Thoughts?
Summary of changes
Provide a detailed description of proposed changes.
Proposed area of change
Put an
xin the boxes that apply.apps/tangle-dappapps/tangle-cloudlibs/tangle-shared-uilibs/webb-ui-componentsAssociated issue(s)
Specify any issues that can be closed from these changes (e.g.
Closes #233).Screen Recording
If possible provide screenshots and/or a screen recording of proposed change.