Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM Staking - Unbond & Rebond Tokens Flow #1901

Merged
merged 9 commits into from
Dec 21, 2023

Conversation

devpavan04
Copy link
Member

@devpavan04 devpavan04 commented Dec 19, 2023

Summary of changes

  • Remove Update Nominations button and Change Reward Destination buttons from nominator stats container as they will will be moved to manage dropdown of Nominations and Payouts tables.
  • Remove current Payment Destination display from nominator stats container.
  • Add Unbond tokens flow.
  • Show Unbonding tokens along with Remaining Eras in nominator stats container.
  • Add Rebond tokens flow.

Proposed area of change

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/testnet-leaderboard
  • apps/faucet
  • libs/webb-ui-components

Reference issue to close (if applicable)

Screen Recording (Unbond & Rebond Flow)

CleanShot.2023-12-20.at.05.56.00.mp4

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit b169ac8
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/6583f677ee31f70008c00893
😎 Deploy Preview https://deploy-preview-1901--hubble-stats.netlify.app/500
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for testnet-leaderboard ready!

Name Link
🔨 Latest commit b169ac8
🔍 Latest deploy log https://app.netlify.com/sites/testnet-leaderboard/deploys/6583f67758e6f10008f64c32
😎 Deploy Preview https://deploy-preview-1901--testnet-leaderboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit b169ac8
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/6583f67747837e00085f10ff
😎 Deploy Preview https://deploy-preview-1901--tangle-dapp.netlify.app/500
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devpavan04 devpavan04 marked this pull request as draft December 19, 2023 12:05
Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for zkexplorer ready!

Name Link
🔨 Latest commit b169ac8
🔍 Latest deploy log https://app.netlify.com/sites/zkexplorer/deploys/6583f677db702a0008578af8
😎 Deploy Preview https://deploy-preview-1901--zkexplorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@monaiuu
Copy link
Contributor

monaiuu commented Dec 19, 2023

@devpavan04

We probably need a better approach in handling the display of eras remaining for unbonding tokens, as user may unbond tokens at different eras (i.e., 5TNT at era X, 10TNT at era Y), and these 15TNT would have different eras remaining.

I can look into this and propose other ways of displaying, if you have any ideas lmk too.

@devpavan04 devpavan04 marked this pull request as ready for review December 20, 2023 14:00
export const unBondTokens = async (
nominatorAddress: string,
numberOfTokens: number
): Promise<`0x${string}`> => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like type 0x${string} is a type that is used a lot through out our dapps and libs, maybe we can create this type somewhere and reuse it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm addressing this in my current working PR.

@vutuanlinh2k2 vutuanlinh2k2 self-requested a review December 21, 2023 07:27
@vutuanlinh2k2
Copy link
Contributor

left some comments

@devpavan04 devpavan04 merged commit e2a9392 into develop Dec 21, 2023
18 checks passed
@devpavan04 devpavan04 deleted the PS/staking-unbond-rebond-flow branch December 21, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add rebonding feature for EVM Staking [TASK] Implement unbonding flow for staking withdrawal
3 participants