-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM Staking - Unbond & Rebond Tokens Flow #1901
Conversation
✅ Deploy Preview for hubble-stats ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testnet-leaderboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zkexplorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We probably need a better approach in handling the display of I can look into this and propose other ways of displaying, if you have any ideas lmk too. |
export const unBondTokens = async ( | ||
nominatorAddress: string, | ||
numberOfTokens: number | ||
): Promise<`0x${string}`> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like type 0x${string}
is a type that is used a lot through out our dapps and libs, maybe we can create this type somewhere and reuse it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm addressing this in my current working PR.
left some comments |
Summary of changes
Update Nominations
button andChange Reward Destination
buttons from nominator stats container as they will will be moved tomanage
dropdown ofNominations
andPayouts
tables.Payment Destination
display from nominator stats container.Unbond
tokens flow.Unbonding
tokens along withRemaining Eras
in nominator stats container.Rebond
tokens flow.Proposed area of change
apps/bridge-dapp
apps/hubble-stats
apps/stats-dapp
apps/tangle-dapp
apps/testnet-leaderboard
apps/faucet
libs/webb-ui-components
Reference issue to close (if applicable)
Screen Recording (Unbond & Rebond Flow)
CleanShot.2023-12-20.at.05.56.00.mp4