Update jsonschema to 0.28.1, support drafts 2019-09 and 2020-12 #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
commented
Jan 9, 2025
| } | ||
| jsonschema::paths::PathChunk::Keyword(_) => {} |
There was a problem hiding this comment.
Not quite sure what this was but I couldn't figure out what the equivalent was based on the release notes and migration guide of jsonschema. I'll try to take another look later this week when I have more time.
| self.cache | ||
| .get_schema(url) | ||
| .get_schema(&Url::parse(uri.as_str())?) |
There was a problem hiding this comment.
Since jsonschema now uses fluent_uri:Uri instead of url::Url, we convert the Uri back to Url to avoid refactoring other major areas of Taplo to use fluent_uri.
| let mut external_schema_requests: FuturesUnordered<_> = errors | ||
| .iter() | ||
| .filter_map(|err| { | ||
| if let ValidationErrorKind::Referencing(ReferencingError::Unretrievable { |
There was a problem hiding this comment.
I believe this here ValidationErrorKind::Referencing(ReferencingError::Unretrievable) should be what we want to refer to external schema errors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #497, jsonschema now supports both of drafts (#497 (comment)).