add remote workflow trigger binaries.yml #429
Conversation
There was a problem hiding this comment.
This should be all ready to go, but we will have to merge tablelandnetwork/js-validator#6 before this workflow will be able to successfully trigger a pull request in js-validator
| js-release: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ success() }} | ||
| needs: [binaries] |
There was a problem hiding this comment.
Using if + needs allows us to wait until all of the builds have succeeded before we trigger the js-validator workflow that will download them.
| - name: PR to publish this release via the npm package | ||
| uses: actions/github-script@v6 | ||
| with: | ||
| github-token: ${{ secrets.TEXTILEIO_MACHINE_ACCESS_TOKEN }} |
There was a problem hiding this comment.
We need to ensure that this secret is available.
cc: @asutula @carsonfarmer
| // it and match standard symantics in the js ecosystem | ||
| let version = '${{ github.ref_name }}'; | ||
| if (/^v[0-9]/.test(version)) { | ||
| version = version.slice(1); |
There was a problem hiding this comment.
This check will ensure that if a release is named v1.0.0 or 1.0.0 the resulting version matches npm and semver, i.e. 1.0.0
|
cc: @carsonfarmer this is the PR corresponding to tablelandnetwork/js-validator#6. |
Overview
This pr adds a job to the end of the binaries.yml workflow. The job is setup to wait until the building of the binaries is finished, then it will trigger a workflow in the js-validator repo.
Details
The workflow that is triggered in the js-validator repo does a few things:
See tablelandnetwork/js-validator#6 for all the details on what happens in js-validator.
One nuance to the separation of js-validator and this repository is that we can manually update the pull request with alternative builds like M1 ect... if someone on the team wants to experiment with a different arch + os.
cc: @brunocalza