Add flag to optionally upload CF template to s3 bucket #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
|
@mikkeloscar no test? |
|
Will try to come up with some test. It's hard to fully test in unit test as it's mostly AWS s3 and cloudformation interaction that needs to be tested. |
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
|
@szuecs I added a test for the new code paths. It's mocking the API so it's not testing that much, but better than nothing :) |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are many egress routes defined in a cluster, the CF stack template can grow to a size not accepted by Cloudformation anymore. The workaround for this is to upload the template to s3 and reference the s3 url in the CF stack.
This PR adds an optional flag
--cf-template-bucketwhich takes the name of an s3 bucket as argument which is used to upload the template.It's assumed that the s3 bucket lifecycle is managed outside of the controller and that the controller has access to write to the bucket for uploading the templates.