Skip to content

Commit

Permalink
Merge pull request #1263 from Kilian/show-actions-aria
Browse files Browse the repository at this point in the history
Add explicit accessible names to show actions
  • Loading branch information
wesbos authored Oct 24, 2023
2 parents dbf0c4a + c24c497 commit 5729439
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions src/lib/ListenLinks.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@
class="icon"
target="_blank"
title="Listen on Spotify"
aria-label="Spotify"
href="https://open.spotify.com/search/syntax.fm {encodeURI(show.title)}/episodes"
>
<Icon name="spotify" />
</a>
<a
class="icon"
title="Listen on Apple Podcasts"
aria-label="Apple Podcasts"
target="_blank"
href="https://podcasts.apple.com/ca/podcast/syntax-tasty-web-development-treats/id1253186678"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,19 @@
<div class="show-actions zone" style="--bg: var(--black); --fg: var(--white);">
<div class="show-actions-flex">
<button on:click={() => player.play_show(show)} data-testid="play-show">
<Icon name="play{$player.current_show?.number === show.number ? 'ing' : ''}" />
<Icon title="" name="play{$player.current_show?.number === show.number ? 'ing' : ''}" />
Play{$player.current_show?.number === show.number ? 'ing' : ''} Episode {show.number}
</button>
<span>or</span>
<ListenLinks {show} />
</div>
<div>
<a class="icon" title="Download Episode" download href={show.url}>
<a class="icon" title="Download Episode" aria-label="Download" download href={show.url}>
<Icon name="download" />
</a>
<a
title="Edit Show Notes"
aria-label="Edit Show Notes"
class="icon"
href={'https://github.com/syntaxfm/website/tree/main' + show.md_file}
>
Expand Down

1 comment on commit 5729439

@vercel
Copy link

@vercel vercel bot commented on 5729439 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

syntax-website – ./

syntax-website-git-main-syntax.vercel.app
syntax.fm
beta.syntax.fm
syntax-website-syntax.vercel.app
www.syntax.fm

Please sign in to comment.