Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added waitFor() calls in submit form tests to ensure crawler state #656

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

yohang
Copy link
Contributor

@yohang yohang commented Jan 8, 2025

ClientTest::testSubmitForm() is randomly failing.

This PR adds a waitFor() call after form submits to fix the test.

@yohang yohang force-pushed the fix/flaky-form-test branch 2 times, most recently from be8428b to 08535a5 Compare January 9, 2025 09:44
@yohang yohang marked this pull request as ready for review January 9, 2025 09:53
@yohang yohang force-pushed the fix/flaky-form-test branch from 08535a5 to 6376a10 Compare January 9, 2025 10:19
@yohang yohang changed the title ci: Added waitFor() calls in submit form tests to ensure crawler state test: Added waitFor() calls in submit form tests to ensure crawler state Jan 9, 2025
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I would like to find the underlying issue, but it's still better than a flaky CI.

@dunglas dunglas merged commit 1fb612b into symfony:main Jan 9, 2025
19 checks passed
HypeMC added a commit to HypeMC/panther that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants