perf(es/minifier): Add cache for collect_infects_from

[kdy1]

Description:

Note: This is conceptually correct, but currently it degrades the performance.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c2479cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kdy1]

cc @CPunisher Do you have an idea for better caching? *const Function does not look good to me.

[CPunisher]

cc @CPunisher Do you have an idea for better caching? *const Function does not look good to me.

The point is to determine an unique id for a function node. Maybe Ident, Span...Since we don't have node id, we may need to find the unique id based on the context.

BTW does it handle a node many times?

[kdy1]

@CPunisher Yeap. I wrote about them in #9927.

While visiting nodes for usage analysis, it calls collect_infects_from on the node, but while recursing into a node from the usage analyzer, it calls collect_infects_from on a child node again.

[CPunisher]

@CPunisher Yeap. I wrote about them in #9927.

While visiting nodes for usage analysis, it calls collect_infects_from on the node, but while recursing into a node from the usage analyzer, it calls collect_infects_from on a child node again.

I see. If it is hard to cache the result, can we avoid repeated analysis? That means we can stop collect_infects_from going deeper since we know we will handle inner nodes later.