Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build .scss files even when used as a remote-theme #8

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kousu
Copy link

@kousu kousu commented Nov 14, 2021

If I put:

# Gemfile

# [ ... ]
# If you want to use GitHub Pages, remove the "gem "jekyll"" above and
# uncomment the line below. To upgrade, run `bundle update github-pages`.
gem "github-pages", group: :jekyll_plugins
# [ ... ]
# _config.yml

# [ ... ]
remote_theme: svmiller/steve-ngvb-jekyll-template
plugins: 
  - jekyll-remote-theme # add this line to the plugins list if you already have one

# [ ... ]

and build:

bundler-2.7 exec jekyll serve

then main.css is never built, and the site renders uselessly:

    Server address: http://127.0.0.1:4000/
  Server running... press ctrl-c to stop.
[2021-11-13 23:00:14] ERROR `/css/main.css' not found.

aaaa

Moving /css -> /assets/css seems to fix it (a tip I picked up from https://github.com/mmistakes/minimal-mistakes):

bbbb

I'm guessing this would be needed if you ever packaged this as a gem too.

@kousu kousu marked this pull request as draft November 14, 2021 04:03
If I put:
```

gem "github-pages", group: :jekyll_plugins
```

```

remote_theme: svmiller/steve-ngvb-jekyll-template
plugins:
  - jekyll-remote-theme # add this line to the plugins list if you already have one

```

and build:

```
bundler-2.7 exec jekyll serve
```

then `main.css` is never built, and the site renders uselessly:

```
    Server address: http://127.0.0.1:4000/
  Server running... press ctrl-c to stop.
[2021-11-13 23:00:14] ERROR `/css/main.css' not found.
```

Moving /css/main.scss -> /assets/css/main.scss gets it built.
I don't know why this works and what you have doesn't, especially
since what you have works when used *directly* (not as a remote-theme).
But I'm not going to dig too much deeper.

I'm guessing this would be needed if you ever packaged this as a gem too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant