Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nav fixed height #915

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

thecalcc
Copy link
Contributor

STT-129

@thecalcc
Copy link
Contributor Author

thecalcc commented Feb 17, 2025

Removing this so that space between navbar and fields in authoring looks better. Also in my opinion if we need some default we can do min-height or padding. Or handle that in the specific usage of this navbar

Before:
image

After:
image

@tomaskikutis
Copy link
Member

You'll be verifying usages right? Should be authoring-react only? If not, we'd need to introduce this via a prop and only do conditionally.

@thecalcc
Copy link
Contributor Author

You'll be verifying usages right? Should be authoring-react only? If not, we'd need to introduce this via a prop and only do conditionally.

I've verified them - it's only used in authoring react, could you approve it so I can merge it to my other pr on client core

@tomaskikutis
Copy link
Member

it's only used in authoring react,

double check if it look ok too when creating articles using authoring-react

@thecalcc
Copy link
Contributor Author

it's only used in authoring react,

double check if it look ok too when creating articles using authoring-react

Yep, I did check it
image

@thecalcc thecalcc merged commit afa0edf into superdesk:develop Feb 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants