Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Togglebox performance improvements #911

Conversation

tomaskikutis
Copy link
Member

Do not render children if togglebox was never opened.

@tomaskikutis tomaskikutis requested a review from thecalcc February 5, 2025 19:53
Copy link
Contributor

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works in general, but not if the toggle box includes a file input, I have found these needs to be rendered still to contain the data uploaded.
Should we have a prop maybe that forces to render children when closed?

@tomaskikutis
Copy link
Member Author

What's the issue with a file input? Once children mount - they will remain mounted even if togglebox is later collapsed.

@MarkLark86
Copy link
Contributor

What's the issue with a file input? Once children mount - they will remain mounted even if togglebox is later collapsed.

Whoops sorry, I missed that wasOpened state. All good then 👍

@tomaskikutis tomaskikutis merged commit 2bb06ce into superdesk:develop Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants