-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced the CSS of NewsShelter Section #630
base: master
Are you sure you want to change the base?
Enhanced the CSS of NewsShelter Section #630
Conversation
Enhanced CSS of NewsShelter section
Updated structure of NewsShelter Section
@quozl Please Review it |
Backward link to old pull request; #629 You haven't fixed the commit messages as already mentioned by @vidipsingh. You have changed css/airspace.css against our frequent advice not to do so as it makes it harder for us to upgrade the theme using upstream source code. Looks like you haven't been reading other pull requests, commit history or our community documentation. i.e. you don't seem to be taking care, and you're placing the burden on reviewers. @chimosky please review. 😁 |
I don't know why you keep closing pull requests. None of the changes we've requested would require a new pull request. |
@quozl Sorry for the ping. I am new to open source and am struggling to fully understand the contribution process. Could you please let me know what I did wrong and how I can fix it? |
I'm happy to tell you what you did wrong, but won't take the time to tell you how to fix it, because
We've given feedback in this pull request and your previous one. I don't think we should repost that feedback, you should scroll up, read it, and if there's something you don't understand (about what you did wrong, not about how to fix it) please ask. If you don't know how to fix it, there's Google, our Matrix channel, and documentation for Git, GitHub, and everything else. Other pull requests and issues in the repository may also help you, both open and closed. |
Description
This pull request introduces design enhancements to the NewsShelter section, focusing on the email input field and the subscribe button. These updates aim to deliver a more polished and user-friendly interface, aligned with modern design practices, while improving the overall user experience.
Changes Made
Email Input Field Enhancements
required
attribute for improved form validation.Subscribe Button Enhancements
Scoped Styles
<style>
tags to ensure they do not interfere with global styles.Impact
Enhanced User Experience
Improved Accessibility
Better Maintainability
Screenshots
2 After Enhancements: