record cancel works #4260
Merged
record cancel works #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but I noticed that the string "Enter file name" is not set up for translation. Nor is the alert you added. Please address that. (Recall that the _() method is all you need to add. e.g., _("Enter file name") to invoke translation.) |
|
On using _( ) no translation took place. I am investigating why. Perhaps because it is a window prompt? I also find out that many of the messages are not being translated. |
|
Thx. Could also change "click on stop sharing" to "Click on stop sharing"? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier on clicking "Cancel" in the prompt saved the video. With this PR, it won't save the recorded video if "Cancel" is clicked.
@walterbender Please check this PR.