Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Notification timeout to widgets #4256

Merged

Conversation

justin212407
Copy link
Contributor

Description:

This PR resolves issue #4255 by introducing a notification timeout feature. With this enhancement, notifications automatically disappear after a set duration, eliminating the need for manual dismissal. This improvement ensures a smoother and more user-friendly experience.

Changes Made:

Added Notification Timeout Logic:

Introduced a timeout feature that automatically hides notifications after a specified duration of 3 seconds, building on the functionality initiated in PR #4162. This enhancement ensures notifications dismiss themselves seamlessly, eliminating the need for manual user intervention while maintaining the integrity of the codebase.

Screenshots/Video:

Untitled.video.-.Made.with.Clipchamp.3.mp4

Checklist:

  • My changes adhere to the project's contribution guidelines.
  • Code changes are implemented.
  • Notification timeout functionality works as expected.

@MostlyKIGuess
Copy link
Member

Great thought but what if the user wants to read it for more than 3 seconds?

@justin212407
Copy link
Contributor Author

@MostlyKIGuess I mean those statements are not too big for the users to take too much time to read them also 3 seconds is the alloted time as it builds on the functionality initiated in PR #4162 to maintain uniformity in the codebase as clearly mentioned in the pr.

@justin212407
Copy link
Contributor Author

@walterbender please review this

@MostlyKIGuess
Copy link
Member

@MostlyKIGuess I mean those statements are not too big for the users to take too much time to read them also 3 seconds is the alloted time as it builds on the functionality initiated in PR #4162 to maintain uniformity in the codebase as clearly mentioned in the pr.

Yeah makes sense, good work dude

@justin212407
Copy link
Contributor Author

@MostlyKIGuess thanks mate

@walterbender walterbender merged commit cb90f92 into sugarlabs:master Jan 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants