Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Search Bar Design for Better UI Consistency #4254

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

AliyanA1
Copy link
Contributor

@AliyanA1 AliyanA1 commented Jan 10, 2025

The search bar's width was overly extended, making it appear disproportionate compared to other UI elements. Its color didn't align well with the sidebar, leading to a slight mismatch in the visual theme of the interface.

Screenshot from 2025-01-10 22-54-57

After:
Screenshot from 2025-01-10 22-47-10
The search bar's width has been adjusted to create a balanced and proportional layout. Its color now matches the sidebar, ensuring a cohesive and aesthetically pleasing design that enhances the overall user experience.

@FirePheonix
Copy link
Contributor

FirePheonix commented Jan 11, 2025

hey bro, I think I did the same job in pull request #4252
Wasn't the issue to edit the overflowing SearchBar Widget that appeared on clicking in the first place??

@AliyanA1
Copy link
Contributor Author

Hey @FirePheonix ,

I noticed your changes in the pull request, and I appreciate the effort you’ve put into addressing the issue. However, I believe my approach better aligns with the original intent of the issue.

The issue seemed to focus on fixing the overflowing SearchBar Widget to make it more user-friendly, especially for children using Music Blocks. My changes focused on adjusting the width and color of the SearchBar. While my adjustment slightly shortened the SearchBar, it maintained a child-friendly experience by avoiding overlap, which could confuse or visually overwhelm young users.

On the other hand, your approach of overlapping the UI may keep the design consistent but could make the SearchBar less intuitive and visually cluttered, especially for kids interacting with it. Keeping the UI simple and clear is crucial for Music Blocks’ younger audience.

I think we can both agree that user-friendliness for children is a priority here. Let me know if you’d like to discuss further! 😊

@AliyanA1
Copy link
Contributor Author

Hi @walterbender , I’ve created a PR (#4254 ) and would love to hear your feedback. I’m excited to contribute to Music Blocks and hope this aligns with the project’s goals. Please let me know if any changes are needed. Thank you! 😊

@walterbender walterbender merged commit 676fe6f into sugarlabs:master Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants