Fixes #3847 Bug Inconsistent zoom behavior #4148
Conversation
|
@walterbender Please Review, issue is #3847 |
|
How did you test this? |
|
@walterbender Initially, the blocks would get stuck when zooming in/out Screen.Recording.2024-12-19.at.9.52.00.AM.mp4 |
|
@walterbender Just refreshing the canvas did not solve the issue, so I added a clearcache method and stage update. I have tested with multiple blocks, the zoom is working fine now. Screen.Recording.2024-12-19.at.11.40.18.AM.mp4 |
|
It seems to work for the most part but maybe there is still an issue with some of the block artwork. |
|
Yes it seems I have to update cache for bitmap also. @walterbender pls review Screen.Recording.2024-12-20.at.1.42.50.PM.mp4 |
jivansh77
force-pushed
the
inconsistentZoom
branch
from
f5bdae3 to
702fd48
Compare
|
@walterbender Any idea why the smoke test is failing |
|
It is unrelated to your PR. It is a misconfiguration somewhere. |
|
@walterbender Yes, I figured, so far the only issue I am facing is when zooming multiple times in quick succession it cannot update the cache, which causes some of the blocks to get stuck. So shall I add a debounce of 250ms to prevent this. Otherwise, it works as expected |
|
A debounce is a good idea. |
|
@walterbender Pls review |
|
Something is not right. It was working much better before. Now it is slow and doesn't complete. |
|
@walterbender Yes, I noticed too, this happens bcos I called the container.cache(). If I don't, it works much better but then I am getting these errors in the console for some reason. I think it might be bcos of some EaseIJS requirement. But I'm trying to find a way around this. |
|
@walterbender I have figured out a way, by updating the refreshCanvas function, it now works the way it was but without any errors, pls review |
Initially, blocks would get stuck when Zooming In/Out.
Key Changes: