Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:added tests to musicutils.js #4147

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

BeNikk
Copy link
Contributor

@BeNikk BeNikk commented Dec 15, 2024

Pull Request: Add Remaining Tests from getOscillatorTypes to base64Encoded

Summary

This pull request introduces unit tests for the functions in the musicutils.js file, specifically covering functionality from getOscillatorTypes to base64Encoded.

Changes

  • Added unit tests

Additional Notes

The remaining tests for other functions in the project will be handled by Aman Singh through their GitHub contributions.

Checklist

  • Unit tests added for getOscillatorTypes to base64Encoded.
  • All tests verified and passed successfully.

Screenshot from 2024-12-15 19-27-12

@BeNikk
Copy link
Contributor Author

BeNikk commented Dec 15, 2024

@walterbender created this draft PR for functions in this musicutils.js, rest of the functions will be covered by @Aman1919 as discussed.

@BeNikk BeNikk marked this pull request as ready for review December 16, 2024 21:39
@Aman1919
Copy link
Contributor

Aman1919 commented Dec 17, 2024

@walterbender Can you merge this if everything looks good, and I'll create a separate PR for the remaining functions afterward.

@walterbender walterbender merged commit cf031bd into sugarlabs:master Dec 19, 2024
4 checks passed
@BeNikk BeNikk deleted the add-tests-musicutils branch December 19, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants