"AccidentalBlockBug"

[falgun143]

Solves #3772 .
@walterbender Plz review.

Music.Blocks.is.a.collection.of.tools.for.exploring.fundamental.musical.concepts.in.a.fun.way.-.Google.Chrome.2024-02-24.20-32-26.mp4

[walterbender]

I don't think this is the best way to fix this problem. Rather than letting text and number args match, better to make the accidental block accept any input.

[falgun143]

@walterbender As suggested ,Type1 is the moving block which can be any of these three(["numberout", "anyout","textout"]) as we want to insert.And type2 corresponds to the nonmoving block which is accidental block(numberin),Just added textout to alreday existing condition.

[walterbender]

The basic types are number in <---> number out and string in <---> string out. There is another type, any in <----> number or string type. I am suggesting that since we can use either a number or a string with the accidental block, it should be any in. The change you had made in your commit would impact every block that has number in, which is not what we want.

[falgun143]

@walterbender without changing the conditions of testConnections(As it may effect other blocks),I changed the the second dockType of accidental block from "numberin" to "anyin".And it works fine.

[walterbender]

Err... still not quite correct. You are overriding every number arg with your commit. We only want to override connection one of the accidental block. The file you want to edit is js/blocks/PitchBlocks.js

[falgun143]

@walterbender Was bit a confused ,I think it is fine now.Plz review.

[walterbender]

Close, but not quite correct. The output of the accidental name block should remain text out. But the input of the acidental block should accept any in.

[falgun143]

@walterbender Is that okay Sir?