Limits number of digits to 12 in number block #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walterbender please review! |
walterbender
reviewed
Jan 9, 2024
js/block.js
Outdated
|
|
||
| if(String(this.value).length > 12) { | ||
| const thisBlock = this.blocks.blockList.indexOf(this); | ||
| this.activity.errorMsg(_("There can be atmost 12 digits"), thisBlock); |
There was a problem hiding this comment.
Also, please put a period at the end of the sentence.
Maybe "Numbers can have at most 12 digits."
|
@walterbender pls review |
|
Even though this issue has already been closed, I noticed that with 12 digits inside the block, overflow still occurs. Is this a concern? Wouldn't it be better to limit it to a smaller quantity within the block? |
|
Maybe ten is better than twelve |
walterbender
pushed a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It displays this error, and the block value defaults back to the previous value