Left Arrow functionality to the left arrow in beginner block #3531
Conversation
|
pls review @walterbender |
|
pls review @samyakshah3008 @walterbender sir I have added what was told by you that we should go back to the tour on click of left arrow of beginneer block tour |
kaurjasleen240305
changed the title
|
Shouldn''t it go to the end of the tour rather than the start of the tour? |
|
@walterbender done sir pls review now onclicking the left arrow of beginner's block we are going to last page only of the overall tour.Also I have added heading changing functionality in overall tour where upon page changing heading also changes as in blocks tour |
|
Done sir @walterbender @samyakshah3008 pls review Music.Blocks.is.a.collection.of.tools.for.exploring.fundamental.musical.concepts.in.a.fun.way.-.Google.Chrome.2024-01-07.21-08-58.mp4 |
|
Thnx sir review of @walterbender is left yet . |
js/widgets/help.js
Outdated
| @@ -69,9 +69,8 @@ class HelpWidget { | |||
| * @param {useActiveBlock} Show help for the active block. | |||
| * @returns {void} | |||
| */ | |||
| _setup(useActiveBlock) { | |||
| _setup(useActiveBlock,page) { | |||
There was a problem hiding this comment.
how about a space after the comma?
js/widgets/help.js
Outdated
| @@ -92,7 +91,12 @@ class HelpWidget { | |||
|
|
|||
| let leftArrow, rightArrow; | |||
| if (!useActiveBlock) { | |||
| this.widgetWindow.updateTitle(_("Take a tour")); | |||
| if(page==0){ | |||
There was a problem hiding this comment.
spaces around operators and before {s
js/widgets/help.js
Outdated
| @@ -411,19 +449,20 @@ class HelpWidget { | |||
| let cell = docById("right-arrow"); | |||
| let rightArrow = docById("right-arrow"); | |||
| let leftArrow = docById("left-arrow"); | |||
|
|
|||
js/widgets/help.js
Outdated
|
|
||
| if(this.index == this.appendedBlockList.length - 1) | ||
| { | ||
| rightArrow.classList.add("disabled") ; | ||
| } | ||
| rightArrow.classList.add("disabled") ; |
There was a problem hiding this comment.
Since you are cleaning up formatting, please remove the space before the ;
kaurjasleen240305
force-pushed
the
br4
branch
2 times, most recently
from
cc9fc12 to
6520a6d
Compare
|
Sorry for inconvenience sir @walterbender but now formatting changes have been done.. you can check.. |
|
pls review @walterbender |
js/widgets/help.js
Outdated
| @@ -58,7 +58,7 @@ class HelpWidget { | |||
| this._helpDiv = document.createElement("div"); | |||
|
|
|||
| // Give the DOM time to create the div. | |||
| setTimeout(() => this._setup(useActiveBlock), 0); | |||
| setTimeout(() => this._setup(useActiveBlock,0), 0); | |||
There was a problem hiding this comment.
please add space after all commas.
js/widgets/help.js
Outdated
| @@ -117,6 +121,12 @@ class HelpWidget { | |||
| if (page > 0){ | |||
| page = page - 1; | |||
| leftArrow.classList.remove('disabled'); | |||
| if (page==0) { | |||
There was a problem hiding this comment.
Please add spaces around all operators.
kaurjasleen240305
force-pushed
the
br4
branch
2 times, most recently
from
7fa05aa to
7e8033b
Compare
added_disabled_property_to_blockHelp_div one_more one_more block_left_arrow_active left_arrow_function_to_last_page formatting changes formatting changes spaces_operators spaces_commans spaces_comman spaces_comman operator_spaces
|
Pls review @walterbender sir spaces in operator added .. |
added_disabled_property_to_blockHelp_div one_more one_more block_left_arrow_active left_arrow_function_to_last_page formatting changes formatting changes spaces_operators spaces_commans spaces_comman spaces_comman operator_spaces
Related to Issue :#3481