Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ActionBlocksJs with JsDoc style #3410

Merged
merged 3 commits into from
Dec 10, 2023
Merged

Updated ActionBlocksJs with JsDoc style #3410

merged 3 commits into from
Dec 10, 2023

Conversation

Karan-Palan
Copy link
Contributor

@Karan-Palan Karan-Palan commented Dec 9, 2023

#2630

Since this process of adding JS doc style to the whole process is very time consuming as I have to understand parts of the codebase, I am adding JS Doc style file by file to keep it error free.

Added the JS Doc style in the following files:

  1. Action Blocks js
  2. Boolean blocks js
  3. Boxes blocks js
  4. Dict blocks js
  5. Drum blocks Js

Kindly review it.
@walterbender @meganindya

@walterbender
Copy link
Member

Seems something went amiss with the indenting in the MR

@Karan-Palan
Copy link
Contributor Author

Used Prettier to fix the indenting. Will check the code next time before PR, this won't happen again

@Karan-Palan
Copy link
Contributor Author

I have made changes in other files . Kindly check @walterbender

@walterbender
Copy link
Member

Looks good so far.

@Karan-Palan
Copy link
Contributor Author

Looks good so far.

Okay. Kindly merge it then Sir. I will work on the other files with time

@walterbender walterbender merged commit cb7e262 into sugarlabs:master Dec 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants