Added_images_at_correctplace #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please review my pr @walterbender |
|
Looks good... but a few questions/comments. |
|
I have changed the point 2 and 3 but I am not able to get this Why did you need to replace the help image PNG? can you please send the image @walterbender |
|
I have changed the getting-started.png as in the old picture screen recording feature and the full screen feature was missing so i have added the new image. |
|
Ah. Makes sense. |
walterbender
reviewed
Dec 5, 2023
documentation/index.html
Outdated
| first two notes are <code>1/4</code> notes; the third note is a <code>1/2</code> note.</p> | ||
| <p><img src="https://rawgithub.com/sugarlabs/musicblocks/master/header-icons/play-button.svg" alt="alt tag" title="play button"></p> | ||
| <p><img src="https://rawgithub.com/sugarlabs/musicblocks/master/header-icons/play-button.svg" alt="play-button.svg" title="play button"></p> |
walterbender
reviewed
Dec 5, 2023
documentation/index.html
Outdated
| @@ -281,12 +281,12 @@ <h2 id="widget-palette">Widget Palette</h2> | |||
| "rhythmic tablature" that should be readable by both those familiar | |||
| with the concepts of rhythm in music and those unfamiliar (but | |||
| familiar with math).</p> | |||
| <p><img src="https://rawgithub.com/sugarlabs/musicblocks/master/guide/matrix1.svg" alt="alt tag" title="Pitch-time Matrix blocks"></p> | |||
| <p><img src="https://rawgithub.com/sugarlabs/musicblocks/master/guide/matrix1.svg" alt="matrix1.svg" title="Pitch-time Matrix blocks"></p> | |||
walterbender
reviewed
Dec 5, 2023
documentation/index.html
Outdated
| <p><em>Pitch-time Matrix</em> blocks clamp is used to define the matrix: | ||
| A row in the matrix is created for each <em>Pitch</em> block and columns are | ||
| created for individual notes, which are created by using <em>Rhythm</em> | ||
| blocks, individual note blocks, or the <em>Tuplet</em> block.</p> | ||
| <p><img src="https://rawgithub.com/sugarlabs/musicblocks/master/guide/matrix6.svg" alt="alt tag" title="Rhythm block"></p> | ||
| <p><img src="https://rawgithub.com/sugarlabs/musicblocks/master/guide/matrix6.svg" alt="matrix6.svg" title="Rhythm block"></p> |
|
@walterbender I think I have corrected all the links due to more links I have missed some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #3394
I have added the links for pictures on the documentation page and also changed the sol 4 to sol 2