New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed_fa#5 #3387

Closed

khadar1020 wants to merge 1 commit into sugarlabs:master from khadar1020:duplicate_pitches

Contributor

khadar1020 commented Dec 2, 2023

issue: #3291

I have removed the duplicate pitch in phrase maker

I think removing that one case is better than removing the fa#5 from the obj itself

once review my PR @pikurasa and tell me any changes are required


          removed_fa#5

Member

walterbender commented Dec 3, 2023

This is not going to work as it removes fa# whether or not it is a duplicate.

Member

walterbender commented Jan 2, 2024

fixed in #3507

walterbender closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet