Update Deprecated Event Usage in SaveInterface Class #3378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase and try again. |
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
|
Closed pull request due to inactivity for more than 63 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #3376 by updating the event handling in the SaveInterface class to align with the latest web standards. The issue reported that the class was using the deprecated returnValue property with the beforeunload event, and according to the latest standards, this should be replaced with the appropriate method for preventing the default behavior.
Changes Made:
Replaced the usage of event.returnValue with event.preventDefault() in the beforeunload event handling in the SaveInterface class.
Ensured that the code aligns with the latest web standards.
Steps to Test:
Open the developer console.
Perform actions that trigger the beforeunload event.
Observe the console for any deprecation warnings. There should be no warnings related to the deprecated use of returnValue.
Please review and merge this pull request. If you have any questions or need further clarification, feel free to reach out.
Thank you!
Best regards,
Navdeep Jajoria