Skip to content

Commit

Permalink
feedback-task: created ref_type oneof field
Browse files Browse the repository at this point in the history
Created a oneof field, "ref_type," (should expand to `ref_type_case` for
generated code) that captures both types of references. The old type,
subtree_ordinal, has also been deprecated.

This addresses feedback in the PR tagged below.

PR: #726
  • Loading branch information
drin committed Feb 26, 2025
1 parent c0906f7 commit 1cd1c49
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions proto/substrait/algebra.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1636,9 +1636,11 @@ message AggregateFunction {
// This rel is used to create references,
// in case we refer to a RelRoot field names will be ignored
message ReferenceRel {
// points to a PlanRel in Plan.relations (ordinal reference)
int32 subtree_ordinal = 1;
oneof ref_type {
// points to a PlanRel in Plan.relations (ordinal reference)
int32 subtree_ordinal = 1 [deprecated = true];

// points to a subtree_anchor in PlanRel (for non-ordinal reference)
uint32 subtree_reference = 2;
// points to a subtree_anchor in PlanRel (for non-ordinal reference)
uint32 subtree_reference = 2;
}
}

0 comments on commit 1cd1c49

Please sign in to comment.