Remove broker resync period for ServiceImport and EndpointSlices #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has proven to be problematic at larger scale, significantly increasing latencies due to the rate limiting. It was put in to easily handle a hypothetical, unlikely edge case where a service namespace is deleted then recreated but the potential performance hit to handle it in this manner isn't worth it. Now that the resource syncer can watch namespaces, we can handle it there. Fixes submariner-io#1623 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1625/tpantelis/no_broker_resync |
dfarrell07
approved these changes
Aug 22, 2024
skitt
approved these changes
Aug 26, 2024
|
🤖 Closed branches: [z_pr1625/tpantelis/no_broker_resync] |
This was referenced Aug 26, 2024
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Aug 26, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Aug 28, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Aug 28, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Aug 28, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Aug 28, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
This was referenced Aug 28, 2024
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 9, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 11, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 11, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 7, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 7, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 9, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 9, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 25, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
dfarrell07
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 25, 2024
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jan 9, 2025
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jan 9, 2025
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Jan 13, 2025
Release notes for submariner-io/lighthouse#1625 Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has proven to be problematic at larger scale, significantly increasing latencies due to the rate limiting. It was put in to easily handle a hypothetical, unlikely edge case where a service namespace is deleted then recreated but the potential performance hit to handle it in this manner isn't worth it. Now that the resource syncer can watch namespaces, we can handle it there.
Fixes #1623