-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Docusaurus v3 #357
Conversation
See the upgrade guide: https://docusaurus.io/docs/migration/v3 Summary: - Bump dependencies: Docusaurus and React - Move `@docusaurus/*` from `devDependencies` to `dependencies` because the official doc describes so. - Rewrite `docusaurus.config.js` in ESM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that Docuasurus v3 was released when catching up on my RSS feeds, and it's terrific to see you've already opened a PR @ybiquitous!
It's looking great.
On the deploy preview, it seems some of our custom CSS isn't active:
The following aren't hidden:
- the 2nd (auto-generated) "Rules" navigation item
- the empty table headers on the Rules page
However, they are hidden when I run the site locally, which is strange. Any ideas?
Should we also adjust the "eslintConfig": { "settings": { "react": { "version": "17.02" }}}
version too?
@jeddy3 Thanks for the review!
Um..., the preview seems to be working in my browser. 🤔
Good catch. Fixed with 345edf5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um..., the preview seems to be working in my browser. 🤔
Very odd. It's probably something on my end then.
Marking as approved.
I upgraded Docusaurus to v3 in #357, but I missed a breaking change for syntax highlighting. This change adds the `prism.additionalLanguages` to the Docusaurus config. See also: - https://docusaurus.io/docs/migration/v3#prism-react-renderer-v20 - https://prismjs.com/#supported-languages
I upgraded Docusaurus to v3 in #357, but I missed a breaking change for syntax highlighting. This change adds the `prism.additionalLanguages` to the Docusaurus config. See also: - https://docusaurus.io/docs/migration/v3#prism-react-renderer-v20 - https://prismjs.com/#supported-languages
Closes #347
See the upgrade guide: https://docusaurus.io/docs/migration/v3
Summary:
@docusaurus/*
fromdevDependencies
todependencies
because the official doc describes so.docusaurus.config.js
in ESM