Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated JSX namespace with direct import #5547

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Efklaz
Copy link

@Efklaz Efklaz commented Jan 26, 2025

The problem was that after the request (Replace deprecated global JSX namespace #4333), I couldn’t use styled-components in React 19. This happened because the .d.ts files were generated without using the React namespace in places where React.JSX was required. Instead, they were generated as plain JSX, which caused errors since, in React 19, this is no longer a global namespace but is scoped to React.

Copy link

changeset-bot bot commented Jan 26, 2025

🦋 Changeset detected

Latest commit: 4921ae2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
styled-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@quantizor
Copy link
Contributor

Has anyone else tested this change and confirmed it is necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants