Mock Payments tests (#3815)

## Summary
* Move most StripePayments and StripePaymentSheet tests to use network
mocking.
* Adjusted DownloadManagerTest timeouts
* Adjusted `maxRetries` in Payment Handler tests

Easier to review by filtering out the `.tail` files:
https://github.com/stripe/stripe-ios/pull/3815/files?file-filters%5B%5D=.m&file-filters%5B%5D=.pbxproj&file-filters%5B%5D=.swift&show-deleted-files=true&show-viewed-files=true

## Motivation
Reduce test time (~18 minutes to ~12 minutes) and flakiness, enforces
that we don't unintentionally change the request parameters.

## Testing
CI

Stripe/StripeiOSTests/APIRequestTest.swift

@@ -12,6 +12,7 @@ import XCTest
 @testable@_spi(STP) import StripeCore
 @testable@_spi(STP) import StripePayments
 @testable@_spi(STP) import StripePaymentSheet
+import StripePaymentsTestUtils
 @testable@_spi(STP) import StripePaymentsUI
 
 class AnyAPIResponse: NSObject, STPAPIResponseDecodable {
@@ -32,9 +33,11 @@ class AnyAPIResponse: NSObject, STPAPIResponseDecodable {
 
 }
 
-class APIRequestTest: XCTestCase {
-    let apiClient = STPAPIClient()
+class APIRequestTest: STPNetworkStubbingTestCase {
+    var apiClient: STPAPIClient!
     override func setUp() {
+        super.setUp()
+        apiClient = STPAPIClient()
         // HTTPBin clone
         apiClient.apiURL = URL(string: "https://luxurious-alpine-devourer.glitch.me")
     }
@@ -244,6 +247,8 @@ class APIRequestTest: XCTestCase {
     }
 
     func test429Backoff() {
+        let oldMaxRetries = StripeAPI.maxRetries
+        StripeAPI.maxRetries = 2
         var inProgress = true
 
         let e = expectation(description: "Request completed")
@@ -267,6 +272,7 @@ class APIRequestTest: XCTestCase {
         }
 
         wait(for: [e, checkedStillInProgress], timeout: 30)
+        StripeAPI.maxRetries = oldMaxRetries
     }
 
     func test429NoBackoff() {

Stripe/StripeiOSTests/ConsumerSessionTests.swift

@@ -13,14 +13,17 @@ import XCTest
 import StripeCoreTestUtils
 @testable@_spi(STP) import StripePayments
 @testable@_spi(STP) import StripePaymentSheet
+import StripePaymentsTestUtils
 @testable@_spi(STP) import StripePaymentsUI
 
-class ConsumerSessionTests: XCTestCase {
+class ConsumerSessionTests: STPNetworkStubbingTestCase {
 
-    let apiClient: STPAPIClient = {
-        let apiClient = STPAPIClient(publishableKey: STPTestingDefaultPublishableKey)
-        return apiClient
-    }()
+    var apiClient: STPAPIClient!
+
+    override func setUp() {
+        super.setUp()
+        apiClient = STPAPIClient(publishableKey: STPTestingDefaultPublishableKey)
+    }
 
     func testLookupSession_noParams() {
         let expectation = self.expectation(description: "Lookup ConsumerSession")

Stripe/StripeiOSTests/LinkSignupViewModelTests.swift

@@ -15,9 +15,10 @@ import XCTest
 @testable@_spi(STP) import StripeCore
 @testable@_spi(STP) import StripePayments
 @testable@_spi(STP) import StripePaymentSheet
+import StripePaymentsTestUtils
 @testable@_spi(STP) import StripePaymentsUI
 
-class LinkInlineSignupViewModelTests: XCTestCase {
+class LinkInlineSignupViewModelTests: STPNetworkStubbingTestCase {
 
     // Should be ~4x the debounce time for best results.
     let accountLookupTimeout: TimeInterval = 4

Stripe/StripeiOSTests/STPApplePayContextFunctionalTest.swift

@@ -13,6 +13,7 @@ import OHHTTPStubs
 @testable import StripeCoreTestUtils
 @testable import StripePayments
 @testable import StripePaymentsObjcTestUtils
+@testable import StripePaymentsTestUtils
 
 class STPTestApplePayContextDelegate: NSObject, STPApplePayContextDelegate {
     func applePayContext(_ context: StripeApplePay.STPApplePayContext, didCreatePaymentMethod paymentMethod: StripePayments.STPPaymentMethod, paymentInformation: PKPayment, completion: @escaping StripeApplePay.STPIntentClientSecretCompletionBlock) {
@@ -27,12 +28,13 @@ class STPTestApplePayContextDelegate: NSObject, STPApplePayContextDelegate {
     var didCreatePaymentMethodDelegateMethod: ((_ paymentMethod: STPPaymentMethod?, _ paymentInformation: PKPayment?, _ completion: @escaping STPIntentClientSecretCompletionBlock) -> Void)?
 }
 
-class STPApplePayContextFunctionalTest: XCTestCase {
+class STPApplePayContextFunctionalTest: STPNetworkStubbingTestCase {
     var apiClient: STPApplePayContextFunctionalTestAPIClient!
     var delegate: STPTestApplePayContextDelegate!
     var context: STPApplePayContext!
 
     override func setUp() {
+        super.setUp()
         delegate = STPTestApplePayContextDelegate()
         let apiClient = STPApplePayContextFunctionalTestAPIClient(publishableKey: STPTestingDefaultPublishableKey)
         apiClient.setupStubs()
@@ -47,6 +49,7 @@ class STPApplePayContextFunctionalTest: XCTestCase {
 
     override func tearDown() {
         HTTPStubs.removeAllStubs()
+        super.tearDown()
     }
 
     func testCompletesManualConfirmationPaymentIntent() {

Stripe/StripeiOSTests/STPBankAccountFunctionalTest.swift

@@ -8,9 +8,10 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 import XCTest
 
-class STPBankAccountFunctionalTest: XCTestCase {
+class STPBankAccountFunctionalTest: STPNetworkStubbingTestCase {
     func testCreateAndRetreiveBankAccountToken() {
         let bankAccount = STPBankAccountParams()
         bankAccount.accountNumber = "000123456789"

Stripe/StripeiOSTests/STPCardFunctionalTest.swift

@@ -8,9 +8,10 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 import XCTest
 
-class STPCardFunctionalTest: XCTestCase {
+class STPCardFunctionalTest: STPNetworkStubbingTestCase {
     func testCreateCardToken() {
         let card = STPCardParams()
 

Stripe/StripeiOSTests/STPE2ETest.swift

@@ -106,6 +106,7 @@ class STPE2ETest: XCTestCase {
     // In this test, a PaymentIntent object is created from an example merchant backend,
     // confirmed by the iOS SDK, and then retrieved to validate that the original amount,
     // currency, and merchant are the same as the original inputs.
+    // (Don't network mock this one!)
     func testE2E() throws {
         continueAfterFailure = false
         let backend = E2EBackend()

Stripe/StripeiOSTests/STPFileFunctionalTest.swift

@@ -8,9 +8,10 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 import XCTest
 
-class STPFileFunctionalTest: XCTestCase {
+class STPFileFunctionalTest: STPNetworkStubbingTestCase {
     func testImage() -> UIImage {
         return UIImage(
             named: "stp_test_upload_image.jpeg",

Stripe/StripeiOSTests/STPPIIFunctionalTest.swift

@@ -8,9 +8,10 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 import XCTest
 
-class STPPIIFunctionalTest: XCTestCase {
+class STPPIIFunctionalTest: STPNetworkStubbingTestCase {
     func testCreatePersonallyIdentifiableInformationToken() {
         let client = STPAPIClient(publishableKey: STPTestingDefaultPublishableKey)
 

Stripe/StripeiOSTests/STPPaymentHandlerFunctionalTest.swift

@@ -13,7 +13,7 @@ import XCTest
 
 // You can add tests in here for payment methods that don't require customer actions (i.e. don't open webviews for customer authentication).
 // If they require customer action, use STPPaymentHandlerFunctionalTest.m instead
-final class STPPaymentHandlerFunctionalSwiftTest: XCTestCase, STPAuthenticationContext {
+final class STPPaymentHandlerFunctionalSwiftTest: STPNetworkStubbingTestCase, STPAuthenticationContext {
     // MARK: - STPAuthenticationContext
     func authenticationPresentingViewController() -> UIViewController {
         return UIViewController()
@@ -29,7 +29,7 @@ final class STPPaymentHandlerFunctionalSwiftTest: XCTestCase, STPAuthenticationC
                 XCTFail(String(describing: error))
                 return
             }
-            STPTestingAPIClient().createPaymentIntent(withParams: [
+            STPTestingAPIClient.shared().createPaymentIntent(withParams: [
                 "confirm": "true",
                 "payment_method_types": ["card"],
                 "currency": "usd",
@@ -73,7 +73,7 @@ final class STPPaymentHandlerFunctionalSwiftTest: XCTestCase, STPAuthenticationC
                 XCTFail(String(describing: error))
                 return
             }
-            STPTestingAPIClient().createPaymentIntent(withParams: [
+            STPTestingAPIClient.shared().createPaymentIntent(withParams: [
                 "confirm": "true",
                 "payment_method_types": ["sepa_debit"],
                 "currency": "eur",
@@ -117,7 +117,7 @@ final class STPPaymentHandlerFunctionalSwiftTest: XCTestCase, STPAuthenticationC
                 XCTFail(String(describing: error))
                 return
             }
-            STPTestingAPIClient().createSetupIntent(withParams: [
+            STPTestingAPIClient.shared().createSetupIntent(withParams: [
                 "confirm": "true",
                 "payment_method_types": ["card"],
                 "payment_method": paymentMethod.stripeId,
@@ -160,7 +160,7 @@ final class STPPaymentHandlerFunctionalSwiftTest: XCTestCase, STPAuthenticationC
                 XCTFail()
                 return
             }
-            STPTestingAPIClient().createSetupIntent(withParams: [
+            STPTestingAPIClient.shared().createSetupIntent(withParams: [
                 "confirm": "true",
                 "payment_method_types": ["sepa_debit"],
                 "payment_method": paymentMethod.stripeId,

Stripe/StripeiOSTests/STPPaymentHandlerTests.swift

@@ -110,6 +110,8 @@ class STPPaymentHandlerStubbedTests: STPNetworkStubbingTestCase {
 class STPPaymentHandlerTests: APIStubbedTestCase {
 
     func testPaymentHandlerRetriesWithBackoff() {
+        let oldMaxRetries = StripeAPI.maxRetries
+        StripeAPI.maxRetries = 1
         STPPaymentHandler.sharedHandler.apiClient = stubbedAPIClient()
 
         stub { urlRequest in
@@ -268,6 +270,7 @@ class STPPaymentHandlerTests: APIStubbedTestCase {
 
         wait(for: [paymentHandlerExpectation, checkedStillInProgress, fetchedSetupIntentExpectation], timeout: 60)
         STPPaymentHandler.sharedHandler.apiClient = STPAPIClient.shared
+        StripeAPI.maxRetries = oldMaxRetries
     }
 }
 

Stripe/StripeiOSTests/STPPaymentIntentFunctionalTest.swift

@@ -11,9 +11,10 @@
 import StripeCoreTestUtils
 @testable@_spi(STP) import StripePayments
 @testable@_spi(STP) import StripePaymentSheet
+import StripePaymentsTestUtils
 @testable@_spi(STP) import StripePaymentsUI
 
-class STPPaymentIntentFunctionalTest: XCTestCase {
+class STPPaymentIntentFunctionalTest: STPNetworkStubbingTestCase {
     func testCreatePaymentIntentWithTestingServer() {
         let expectation = self.expectation(description: "PaymentIntent create.")
         STPTestingAPIClient.shared.createPaymentIntent(

Stripe/StripeiOSTests/STPPaymentMethodAUBECSDebitParamsTests.swift

@@ -8,8 +8,9 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 
-class STPPaymentMethodAUBECSDebitParamsTests: XCTestCase {
+class STPPaymentMethodAUBECSDebitParamsTests: STPNetworkStubbingTestCase {
     func testCreateAUBECSPaymentMethod() {
         let client = STPAPIClient(publishableKey: STPTestingAUPublishableKey)
         let becsParams = STPPaymentMethodAUBECSDebitParams()

Stripe/StripeiOSTests/STPPaymentMethodAUBECSDebitTests.swift

@@ -7,6 +7,7 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 
 @testable@_spi(STP) import Stripe
 @testable@_spi(STP) import StripeCore
@@ -16,7 +17,7 @@ import StripeCoreTestUtils
 
 private var kAUBECSDebitPaymentIntentClientSecret =
     "pi_1GaRLjF7QokQdxByYgFPQEi0_secret_z76otRQH2jjOIEQYsA9vxhuKn"
-class STPPaymentMethodAUBECSDebitTests: XCTestCase {
+class STPPaymentMethodAUBECSDebitTests: STPNetworkStubbingTestCase {
     private(set) var auBECSDebitJSON: [AnyHashable: Any]?
 
     func _retrieveAUBECSDebitJSON(_ completion: @escaping ([AnyHashable: Any]?) -> Void) {

Stripe/StripeiOSTests/STPPaymentMethodAffirmParamsTest.swift

@@ -6,15 +6,15 @@
 //
 
 import Foundation
-import StripeCoreTestUtils
-
 @testable@_spi(STP) import Stripe
 @testable@_spi(STP) import StripeCore
+import StripeCoreTestUtils
 @testable@_spi(STP) import StripePayments
 @testable@_spi(STP) import StripePaymentSheet
+import StripePaymentsTestUtils
 @testable@_spi(STP) import StripePaymentsUI
 
-class STPPaymentMethodAffirmParamsTests: XCTestCase {
+class STPPaymentMethodAffirmParamsTests: STPNetworkStubbingTestCase {
 
     func testCreateAffirmPaymentMethod() throws {
         let affirmParams = STPPaymentMethodAffirmParams()

Stripe/StripeiOSTests/STPPaymentMethodAffirmTests.swift

@@ -6,6 +6,7 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 import XCTest
 
 @testable@_spi(STP) import Stripe
@@ -14,7 +15,7 @@ import XCTest
 @testable@_spi(STP) import StripePaymentSheet
 @testable@_spi(STP) import StripePaymentsUI
 
-class STPPaymentMethodAffirmTests: XCTestCase {
+class STPPaymentMethodAffirmTests: STPNetworkStubbingTestCase {
 
     static let affirmPaymentIntentClientSecret =
         "pi_3KUFbTFY0qyl6XeW1oDBbiQk_secret_8kdpLx37oa5WMrI2xoXThCK9s"

Stripe/StripeiOSTests/STPPaymentMethodAfterpayClearpayParamsTest.swift

@@ -8,8 +8,9 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 
-class STPPaymentMethodAfterpayClearpayParamsTest: XCTestCase {
+class STPPaymentMethodAfterpayClearpayParamsTest: STPNetworkStubbingTestCase {
     func testCreateAfterpayClearpayPaymentMethod() {
         let client = STPAPIClient(publishableKey: STPTestingDefaultPublishableKey)
         let afterpayClearpayParams = STPPaymentMethodAfterpayClearpayParams()

Stripe/StripeiOSTests/STPPaymentMethodAfterpayClearpayTest.swift

@@ -9,8 +9,9 @@
 
 import Stripe
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 
-class STPPaymentMethodAfterpayClearpayTest: XCTestCase {
+class STPPaymentMethodAfterpayClearpayTest: STPNetworkStubbingTestCase {
     var afterpayJSON: [AnyHashable: Any]?
 
     func _retrieveAfterpayJSON(_ completion: @escaping ([AnyHashable: Any]?) -> Void) {

Stripe/StripeiOSTests/STPPaymentMethodAlmaParamsTests.swift

@@ -7,14 +7,15 @@
 
 import Foundation
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 
 @testable@_spi(STP) import Stripe
 @testable@_spi(STP) import StripeCore
 @testable@_spi(STP) import StripePayments
 @testable@_spi(STP) import StripePaymentSheet
 @testable@_spi(STP) import StripePaymentsUI
 
-class STPPaymentMethodAlmaParamsTests: XCTestCase {
+class STPPaymentMethodAlmaParamsTests: STPNetworkStubbingTestCase {
 
     func testCreateAlmaPaymentMethod() throws {
         let almaParams = STPPaymentMethodAlmaParams()

Stripe/StripeiOSTests/STPPaymentMethodAlmaTests.swift

@@ -7,9 +7,10 @@
 
 @testable import Stripe
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 import XCTest
 
-class STPPaymentMethodAlmaTests: XCTestCase {
+class STPPaymentMethodAlmaTests: STPNetworkStubbingTestCase {
 
     static let almaPaymentIntentClientSecret = "pi_3Oz1AfKG6vc7r7YC0VaP6KiE_secret_SxVptpJ5PaAceAYCGetQh8FVv"
 

Stripe/StripeiOSTests/STPPaymentMethodAmazonPayParamsTests.swift

@@ -12,9 +12,10 @@ import StripeCoreTestUtils
 @testable@_spi(STP) import StripeCore
 @testable@_spi(STP) import StripePayments
 @testable@_spi(STP) import StripePaymentSheet
+import StripePaymentsTestUtils
 @testable@_spi(STP) import StripePaymentsUI
 
-class STPPaymentMethodAmazonPayParamsTests: XCTestCase {
+class STPPaymentMethodAmazonPayParamsTests: STPNetworkStubbingTestCase {
 
     func testCreateAmazonPayPaymentMethod() throws {
         let amazonPayParams = STPPaymentMethodAmazonPayParams()

Stripe/StripeiOSTests/STPPaymentMethodAmazonPayTests.swift

@@ -7,9 +7,10 @@
 
 @testable import Stripe
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 import XCTest
 
-class STPPaymentMethodAmazonPayTests: XCTestCase {
+class STPPaymentMethodAmazonPayTests: STPNetworkStubbingTestCase {
 
     static let amazonPayPaymentIntentClientSecret = "pi_3OmQQ0FY0qyl6XeW0H4X6eI0_secret_BerPIzUf8vFy1KXG53iYvX2Zb"
 

Stripe/StripeiOSTests/STPPaymentMethodBancontactParamsTests.swift

@@ -8,8 +8,9 @@
 //
 
 import StripeCoreTestUtils
+import StripePaymentsTestUtils
 
-class STPPaymentMethodBancontactParamsTests: XCTestCase {
+class STPPaymentMethodBancontactParamsTests: STPNetworkStubbingTestCase {
     func testCreateBancontactPaymentMethod() {
         let client = STPAPIClient(publishableKey: STPTestingDefaultPublishableKey)
         let bancontactParams = STPPaymentMethodBancontactParams()

Stripe/StripeiOSTests/STPPaymentMethodBancontactTests.swift

@@ -12,9 +12,10 @@ import StripeCoreTestUtils
 @testable@_spi(STP) import StripeCore
 @testable@_spi(STP) import StripePayments
 @testable@_spi(STP) import StripePaymentSheet
+import StripePaymentsTestUtils
 @testable@_spi(STP) import StripePaymentsUI
 
-class STPPaymentMethodBancontactTests: XCTestCase {
+class STPPaymentMethodBancontactTests: STPNetworkStubbingTestCase {
     private(set) var bancontactJSON: [AnyHashable: Any]?
 
     func _retrieveBancontactJSON(_ completion: @escaping ([AnyHashable: Any]?) -> Void) {