web: new sidebar ui #7081
Open
web: new sidebar ui #7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just gave this a test run. A few bugs:
|
01zulfi
commented
Dec 24, 2024
01zulfi
force-pushed
the
feat/sidebar-ui
branch
2 times, most recently
from
33b18e3 to
85e0162
Compare
thecodrr
requested changes
Jan 2, 2025
Comment on lines
+88
to
+96
| // const children = await getChildNodes(rootId, -1); | ||
| // setNodes(children); | ||
| const nodes = await fetchChildren( | ||
| rootId, | ||
| -1, | ||
| expandedIds, | ||
| getChildNodes | ||
| ); | ||
| setNodes(nodes); |
There was a problem hiding this comment.
Whenever the tree was refreshed, the children of expanded notebooks weren't loaded. This change fixed that
apps/web/src/views/tags.tsx
Outdated
Comment on lines
42
to
49
| useEffect(() => { | ||
| if (location === "sidebar") return; | ||
| tags?.item(0).then((item) => { | ||
| if (item && item?.item) { | ||
| navigate(`/tags/${item.item.id}`); | ||
| } | ||
| }); | ||
| }, [tags, location]); |
There was a problem hiding this comment.
I don't think this is needed.
There was a problem hiding this comment.
This is in case a user manually navigates to app.notesnook.com/tags, we can redirect them to the first tag. Plus this also prevents showing the tags listing in the middle pane.
|
You will also have to run a rebase with |
Signed-off-by: 01zulfi <[email protected]>
01zulfi
force-pushed
the
feat/sidebar-ui
branch
from
85e0162 to
5fbd4ac
Compare
Signed-off-by: 01zulfi <[email protected]>
Signed-off-by: 01zulfi <[email protected]>
Signed-off-by: 01zulfi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 01zulfi [email protected]