shared WASM execution cache #579
Conversation
| @@ -67,6 +77,7 @@ type Tier1Config struct { | |||
| SubrequestsEndpoint string | |||
| SubrequestsInsecure bool | |||
| SubrequestsPlaintext bool | |||
| SharedCacheSize uint64 | |||
There was a problem hiding this comment.
Size in what? Bytes, count, etc?
metrics/metrics.go
Outdated
| @@ -37,6 +37,9 @@ var Tier2RejectedRequestCounter = MetricSet.NewCounterVec( | |||
| "Counter for total Substreams requests the tier2 rejected, by reason (gRPC code reason)", | |||
| ) | |||
|
|
|||
| var ExecutedWasmModules = MetricSet.NewCounter("substreams_executed_wasm_modules", "Counter for total Substreams modules x block for which wasm was executed") | |||
There was a problem hiding this comment.
I don't get the ... x block for part
pipeline/exec/sharedcache.go
Outdated
| callEntries map[string]map[string]*callEntry | ||
| } | ||
|
|
||
| const maxUint64 uint64 = 1<<64 - 1 |
There was a problem hiding this comment.
Not useful, math.MaxUint64 works out of the box
pipeline/exec/sharedcache.go
Outdated
|
|
||
| func NewSharedCache(size uint64) *SharedCache { | ||
| return &SharedCache{ | ||
| headBlock: atomic.NewUint64(maxUint64), |
There was a problem hiding this comment.
| headBlock: atomic.NewUint64(maxUint64), | |
| headBlock: atomic.NewUint64(math.MaxUint64), |
| sync.Mutex | ||
| headBlock *atomic.Uint64 | ||
| size uint64 | ||
| // module_hash -> blockHash -> callEntry |
There was a problem hiding this comment.
Need the "kind" of size, I think it's in block.
pipeline/exec/sharedcache.go
Outdated
| if tracer.Enabled() { | ||
| zlog.Debug("executing wasm call", zap.String("module_hash", moduleHash), zap.Uint64("block_num", clock.Number)) | ||
| } | ||
| metrics.ExecutedWasmModules.Inc() |
There was a problem hiding this comment.
Best would be to link that to the app context, so at least it would to be ever blocking
pipeline/exec/sharedcache.go
Outdated
| if !ok { | ||
| result = &callEntry{clock: clock} | ||
| s.callEntries[clock.Id][moduleHash] = result | ||
| resultLockOwner = true |
There was a problem hiding this comment.
It would be good to add a comment here to explain the overall process that this is going to block other modules that arrives after this one and that it's a write lock because it's going to actually write the results.
pipeline/exec/sharedcache.go
Outdated
| } | ||
|
|
||
| s.Unlock() | ||
|
|
There was a problem hiding this comment.
Maybe it would be better to put that in the else clause above, tied it more closely where it matters.
pipeline/exec/sharedcache.go
Outdated
| argValues map[string][]byte, | ||
| ) error { | ||
| clock := call.Clock | ||
| var resultLockOwner bool |
There was a problem hiding this comment.
| var resultLockOwner bool | |
| // Manually unlocked, pay attention if you add early exit beyond that lock call |
| return | ||
| } | ||
| exec.GlobalSharedCache = sharedCache | ||
| hubSrc.Run() |
There was a problem hiding this comment.
Should we check for errors here, at least for logging purposes?
sduchesneau
force-pushed
the
stepd/sharedbuffer
branch
from
31d9efa to
b64cee1
Compare
adds a cache for module*block executed near the HEAD of the chain, to prevent executing the same foundational modules 5 times whenever a block comes in