fix sign of balance

streamingfast · Nov 30, 2023 · 4b24391 · 4b24391
1 parent 570c22d
commit 4b24391
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/src/maps.rs b/src/maps.rs
@@ -213,8 +213,8 @@ fn find_erc20_balance_changes_algorithm1(
         let change = BalanceChange {
             contract: Hex::encode(&call.address),
             owner: Hex::encode(keccak_address),
-            old_balance: BigInt::from_signed_bytes_be(&storage_change.old_value).to_string(),
-            new_balance: BigInt::from_signed_bytes_be(&storage_change.new_value).to_string(),
+            old_balance: BigInt::from_unsigned_bytes_be(&storage_change.old_value).to_string(),
+            new_balance: BigInt::from_unsigned_bytes_be(&storage_change.new_value).to_string(),
             transaction: Hex::encode(&trx.hash),
             storage_key: Hex::encode(&storage_change.key),
             call_index: call.index,
@@ -266,8 +266,8 @@ fn find_erc20_balance_changes_algorithm2(
             continue;
         }
 
-        let old_balance = BigInt::from_signed_bytes_be(&storage_change.old_value);
-        let new_balance = BigInt::from_signed_bytes_be(&storage_change.new_value);
+        let old_balance = BigInt::from_unsigned_bytes_be(&storage_change.old_value);
+        let new_balance = BigInt::from_unsigned_bytes_be(&storage_change.new_value);
 
         let balance_change = new_balance - old_balance;
         if balance_change < BigInt::zero() {
@@ -279,8 +279,8 @@ fn find_erc20_balance_changes_algorithm2(
         let change = BalanceChange {
             contract: Hex::encode(&original_call.address),
             owner: Hex::encode(keccak_address),
-            old_balance: BigInt::from_signed_bytes_be(&storage_change.old_value).to_string(),
-            new_balance: BigInt::from_signed_bytes_be(&storage_change.new_value).to_string(),
+            old_balance: BigInt::from_unsigned_bytes_be(&storage_change.old_value).to_string(),
+            new_balance: BigInt::from_unsigned_bytes_be(&storage_change.new_value).to_string(),
             transaction: Hex::encode(&trx.hash),
             storage_key: Hex::encode(&storage_change.key),
             call_index: original_call.index,
@@ -307,8 +307,8 @@ fn find_erc20_balance_changes_algorithm2(
             None => continue,
         };
 
-        let old_balance = BigInt::from_signed_bytes_be(&storage_change.old_value);
-        let new_balance = BigInt::from_signed_bytes_be(&storage_change.new_value);
+        let old_balance = BigInt::from_unsigned_bytes_be(&storage_change.old_value);
+        let new_balance = BigInt::from_unsigned_bytes_be(&storage_change.new_value);
 
         let mut balance_change = new_balance - old_balance;
         if balance_change < BigInt::zero() {
@@ -322,8 +322,8 @@ fn find_erc20_balance_changes_algorithm2(
         let change = BalanceChange {
             contract: Hex::encode(&original_call.address),
             owner: Hex::encode(keccak_address),
-            old_balance: BigInt::from_signed_bytes_be(&storage_change.old_value).to_string(),
-            new_balance: BigInt::from_signed_bytes_be(&storage_change.new_value).to_string(),
+            old_balance: BigInt::from_unsigned_bytes_be(&storage_change.old_value).to_string(),
+            new_balance: BigInt::from_unsigned_bytes_be(&storage_change.new_value).to_string(),
             transaction: Hex::encode(&trx.hash),
             storage_key: Hex::encode(&storage_change.key),
             call_index: original_call.index,

diff --git a/src/sinks.rs b/src/sinks.rs
@@ -4,7 +4,7 @@ use substreams_entity_change::pb::entity::EntityChanges;
 use substreams_database_change::pb::database::DatabaseChanges;
 
 #[substreams::handlers::map]
-pub fn graph_out(clock: Clock, balance_changes: BalanceChanges) -> Result<EntityChanges, Error> {
+pub fn graph_out(_clock: Clock, balance_changes: BalanceChanges) -> Result<EntityChanges, Error> {
     let mut tables = substreams_entity_change::tables::Tables::new();
 
     for balance_change in balance_changes.balance_changes {

diff --git a/subgraph.yaml b/subgraph.yaml
@@ -11,7 +11,7 @@ dataSources:
     source:
       package:
         moduleName: graph_out
-        file: ./erc20-balance-changes-v1.1.0.spkg
+        file: ./erc20-balance-changes-v1.2.0.spkg
     mapping:
       kind: substreams/graph-entities
       apiVersion: 0.0.7
diff --git a/substreams.yaml b/substreams.yaml
@@ -1,7 +1,7 @@
 specVersion: v0.1.0
 package:
   name: erc20_balance_changes
-  version: v1.1.0
+  version: v1.2.0
   url: https://github.com/streamingfast/erc20-balance-changes
   image: logo.png
   doc: |