Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added User Events to support SAML logins. #77

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

elainabialkowski
Copy link
Contributor

Fixed tests.
Added UserLoggedInEvent alongside PostLoginEvent.
Added UserFirstTimeLoggedInEvent.

This PR is meant to fix #74.

@stjosh stjosh self-assigned this Sep 19, 2024
@elainabialkowski
Copy link
Contributor Author

It looks like they moved away from ILogger a few months ago in favour of ILogFactory using Psr\Log\LoggerInterface. That seems to be why the test in master is failing.

@stjosh
Copy link
Owner

stjosh commented Sep 21, 2024

@elainabialkowski Many thanks for your contribution which I'll gladly merge!
And absolutely, the logger is an issue of compatibility with NC31 onwards. I have opened #78 for that; it's completely unrelated.

@stjosh stjosh merged commit 88873fa into stjosh:master Sep 21, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users created through SSO/SAML authentication aren't recognized as new users
2 participants