-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users created through SSO/SAML authentication aren't recognized as new users #74
Comments
Hi, thanks for your interest in this app. As this is s hobby project and since I do not have any test setup with SAML/SSO, I cannot afford to investigate issues related to SAML authentication or generally cross-compatibility with other apps. The only tested setup is using auto_groups together with Nextcloud‘s built-in user management / login system. I am happy, though, to accept contributions that fix issues related to other apps as long as these fixes don‘t break the app’s core functionality. For your specific issue, maybe you have the chance to assign automatic groups in the master user system that is used for SSO? Thanks for your understanding. |
Just today i ran into the same issue. |
Many thanks @dermalikmann . Note that we had a similar thing in #42 - it seemed to have worked for sone time, but maybe things have changed again? |
This seems to be an issue with 1.5.3, when rolling back to 1.5.2 it works (tested with Nextcloud 27.1.9.1 and user_saml 5.2.7). |
Hi @Pyttsen - thanks, that's interesting! I have changed the event for the "new users" even from "UserLoggedIn"-Event to "PostLoginEvent". Maybe, SSO/SAML only sends the former... |
Hello! Some clients I'm working for are looking for a feature that auto_groups solves, but require SSO/SAML login. If there's any way I can help move this along, I'd love to volunteer. I can try and get those tests running. Would the user_saml PR also have to be completed and merged before things worked? EDIT: Just noticed there's a PR to add the dispatching of PostLoginEvent. |
Hi @elainabialkowski, thanks for stepping in! As I had mentioned elsewhere, I‘ll gladly accept PRs that are reported to fix the combination of auto_groups and SAML/SSO as long as the core functionality of auto_groups is not affected / degraded and as long as the code of auto_groups is not bloated to make the combination work. Personally, I do neither have the time nor do I have a SAML/SSO setup to investigate/fix the combination. PostLoginEvent dispatching sounds like a perfect, simple candidate to get it running, though. I‘d like it best, since it leaves auto_groups as it is. 😉 Feel free to report back as soon as you have made progress. |
(hopefully!) fixed with v1.6.0 that I have just published now. Many thanks to @elainabialkowski for the contribution! |
If a user account is created through SAML (https://apps.nextcloud.com/apps/user_saml), they are not recognized as part of 'Set Auto Group membership on user creation').
Therefore, the Auto Group is not assigned to the user upon profile creation.
The text was updated successfully, but these errors were encountered: