first pass at adding wallet interface and soroban signing #94
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
| @@ -0,0 +1,37 @@ | |||
| import FreighterApi from "@stellar/freighter-api"; | |||
There was a problem hiding this comment.
Perhaps it's best if we flipped this. This way the frieghter API package could provide the Wallet implementation.
There was a problem hiding this comment.
Ah yeah, that makes sense. The idea being that the freighter-api becomes the default interface that we expect from a wallet.
For added context: We're also talking about creating some helper methods in this lib to allow other browser extensions to quickly implement this expected interface in their own codebase so they can quickly make use of signAndSend and signAuthEntries
| @@ -41,7 +41,8 @@ | |||
| "webpack-cli": "^5.1.1" | |||
| }, | |||
| "dependencies": { | |||
| "@stellar/stellar-sdk": "^11.1.0", | |||
| "@stellar/freighter-api": "^1.7.1", | |||
| "@stellar/stellar-sdk": "stellar/js-stellar-sdk#bindings", | |||
There was a problem hiding this comment.
@piyalbasu just out of curiosity, what's the reason behind this "#bindings" change?
There was a problem hiding this comment.
This was targeted at a branch of stellar-sdk that had the TS bindings update for dev purposes. This work may be merged already. I'll follow up
No description provided.